Google Calendar & Calendly - add configuration errors #18061
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
WalkthroughAdds required input validation to two actions (Calendly Create Scheduling Link and Google Calendar Quick Add Event), updates request parameters for Calendly, and bumps versions for both actions and their packages. No other logic changes. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Action as Calendly Create Scheduling Link
participant API as Calendly API
User->>Action: Run with Owner, other inputs
Action->>Action: Validate Owner (required)
Action->>API: POST /scheduling_links { owner, owner_type=EventType, ... }
API-->>Action: Response
Action-->>User: Summary + API response
sequenceDiagram
participant User
participant Action as Google Calendar Quick Add
participant GC as Google Calendar API
User->>Action: Run with calendarId, text, attendees?
Action->>Action: Validate calendarId (required)
Action->>GC: quickAddEvent(calendarId, text)
GC-->>Action: Event
Action->>GC: (optional) update attendees
GC-->>Action: Updated Event
Action-->>User: Result
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
components/google_calendar/actions/quick-add-event/quick-add-event.mjs (1)
32-34: Strengthen calendarId validation to catch blank strings and non-stringsCurrent check misses cases like an empty string. Recommend a stricter guard.
Apply this diff:
- if (!this.calendarId) { - throw new ConfigurationError("Calendar ID prop is missing or empty. Please provide a valid string representing the calendar's identifier. For example, 'primary' or an email address such as 'user@example.com'"); - } + if (typeof this.calendarId !== "string" || !this.calendarId.trim()) { + throw new ConfigurationError("Missing required prop: calendarId. Provide a valid calendar ID like 'primary' or 'user@example.com'."); + }Optional: If you want to be more permissive, default to "primary" when unset, instead of throwing. If you want that, I can draft the change.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these settings in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (4)
components/calendly_v2/actions/create-scheduling-link/create-scheduling-link.mjs(2 hunks)components/calendly_v2/package.json(1 hunks)components/google_calendar/actions/quick-add-event/quick-add-event.mjs(2 hunks)components/google_calendar/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Lint Code Base
- GitHub Check: pnpm publish
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
🔇 Additional comments (6)
components/calendly_v2/package.json (1)
3-3: Version bump looks goodPatch version increment aligns with non-breaking validation changes elsewhere in the package.
components/google_calendar/package.json (1)
3-3: Version bump approvedPatch release is appropriate for adding validation without behavior changes to existing actions.
components/google_calendar/actions/quick-add-event/quick-add-event.mjs (2)
3-3: Importing ConfigurationError is appropriateCorrect dependency and import path for throwing user-facing configuration errors.
9-9: Action version bump approvedIncrement to 0.1.8 accurately reflects the added validation without API changes.
components/calendly_v2/actions/create-scheduling-link/create-scheduling-link.mjs (2)
2-2: Importing ConfigurationError is correctPrepares the action to surface misconfiguration clearly to users.
8-8: Action version bump approved0.0.7 is appropriate for the added validation and params tweak.
components/calendly_v2/actions/create-scheduling-link/create-scheduling-link.mjs
Show resolved
Hide resolved
michelle0927
moved this from Doing
to Ready for PR Review
in Component (Source and Action) Backlog
GTFalcao
moved this from Ready for PR Review
to Ready for QA
in Component (Source and Action) Backlog
vunguyenhung
moved this from Ready for QA
to Ready for Release
in Component (Source and Action) Backlog
|
Hi everyone, all test cases are passed! Ready for release! |
github-project-automation
bot
moved this from Ready for Release
to Done
in Component (Source and Action) Backlog
This PR addresses the specific components identified in issue #17693.
I'm leaving the original issue under Prioritized so that it can continue to be tracked internally.
Summary by CodeRabbit