[ACTION] trengo - close ticket #19278
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
WalkthroughAdds a new "Close Ticket" action and related app methods/prop for Trengo, plus numerous metadata version bumps across Trengo actions and sources and a package version update to 0.6.0. Changes
Sequence Diagram(s)sequenceDiagram
%% styling: subtle colored boxes for components
participant A as Close Ticket Action
participant B as Trengo App
participant C as Trengo API
rect rgb(240,248,255)
A->>B: closeTicket({ $, ticketId, data:{ticket_result_id} })
end
B->>C: POST /tickets/{ticketId}/close (body: { ticket_result_id })
C-->>B: 200/response
B-->>A: API response
A->>A: $.export("$summary","Successfully closed ticket")
A-->>User: return API response
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jcortes
force-pushed
the
trengo-new-component-close-ticket
branch
from
5123954 to
8296c63
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
components/trengo/sources/new-outbound-message/new-outbound-message.mjs (1)
7-20: Version bump is fine; fix minor typo in summary.The metadata version update to
"0.0.7"looks good. There’s a minor typo in the summary string ("New outbund message event"); consider changing it to"New outbound message event"for clarity.components/trengo/sources/phone-call-missed/phone-call-missed.mjs (1)
7-18: Version bump is fine; consider tightening description text.The version change to
"0.0.7"is fine. The description string reads a bit awkwardly ("Emit new event when an phone call missed"); consider something like"Emit a new event when a phone call is missed."to improve readability.components/trengo/sources/new-internal-note/new-internal-note.mjs (1)
7-20: Update summary text to match “New Internal Note” semantics.The version bump to
"0.0.7"looks good. Thesummarycurrently says"New ticket label added event", which doesn’t match this being an internal note source. Consider updating it to something like"New internal note event: …"so the emitted events are self‑descriptive.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (27)
components/trengo/actions/attach-label/attach-label.mjs(1 hunks)components/trengo/actions/close-ticket/close-ticket.mjs(1 hunks)components/trengo/actions/create-contact/create-contact.mjs(1 hunks)components/trengo/actions/find-contacts/find-contacts.mjs(1 hunks)components/trengo/actions/get-label/get-label.mjs(1 hunks)components/trengo/actions/get-message/get-message.mjs(1 hunks)components/trengo/actions/list-articles/list-articles.mjs(1 hunks)components/trengo/actions/list-labels/list-labels.mjs(1 hunks)components/trengo/actions/list-messages/list-messages.mjs(1 hunks)components/trengo/actions/list-tickets/list-tickets.mjs(1 hunks)components/trengo/actions/log-a-voice-call/log-a-voice-call.mjs(1 hunks)components/trengo/actions/send-a-message/send-a-message.mjs(1 hunks)components/trengo/actions/send-a-team-chat-message/send-a-team-chat-message.mjs(1 hunks)components/trengo/actions/send-a-ticket-message/send-a-ticket-message.mjs(1 hunks)components/trengo/actions/send-a-whatsapp-message-template/send-a-whatsapp-message-template.mjs(1 hunks)components/trengo/package.json(1 hunks)components/trengo/sources/new-inbound-message/new-inbound-message.mjs(1 hunks)components/trengo/sources/new-internal-note/new-internal-note.mjs(1 hunks)components/trengo/sources/new-outbound-message/new-outbound-message.mjs(1 hunks)components/trengo/sources/phone-call-ended/phone-call-ended.mjs(1 hunks)components/trengo/sources/phone-call-missed/phone-call-missed.mjs(1 hunks)components/trengo/sources/phone-call-started/phone-call-started.mjs(1 hunks)components/trengo/sources/ticket-closed/ticket-closed.mjs(1 hunks)components/trengo/sources/ticket-label-added/ticket-label-added.mjs(1 hunks)components/trengo/sources/ticket-reopened/ticket-reopened.mjs(1 hunks)components/trengo/sources/voice-call-recorded/voice-call-recorded.mjs(1 hunks)components/trengo/trengo.app.mjs(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-10-20T01:01:02.970Z
Learnt from: js07
Repo: PipedreamHQ/pipedream PR: 18744
File: components/slack_v2/actions/send-large-message/send-large-message.mjs:49-64
Timestamp: 2025-10-20T01:01:02.970Z
Learning: In components/slack_v2/actions/send-large-message/send-large-message.mjs, the metadata_event_payload prop is typed as string, so the code only needs to handle string-to-JSON parsing and does not need to handle object inputs.
Applied to files:
components/trengo/actions/get-message/get-message.mjscomponents/trengo/actions/send-a-message/send-a-message.mjscomponents/trengo/actions/send-a-ticket-message/send-a-ticket-message.mjscomponents/trengo/actions/send-a-team-chat-message/send-a-team-chat-message.mjscomponents/trengo/actions/list-tickets/list-tickets.mjscomponents/trengo/sources/new-outbound-message/new-outbound-message.mjs
🧬 Code graph analysis (1)
components/trengo/trengo.app.mjs (1)
components/trengo/actions/close-ticket/close-ticket.mjs (1)
response(30-36)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
🔇 Additional comments (24)
components/trengo/actions/get-message/get-message.mjs (1)
7-7: Version metadata update looks correct.The action’s version bump to
"0.0.3"is consistent with the rest of the Trengo changes; no behavioral issues spotted.components/trengo/actions/find-contacts/find-contacts.mjs (1)
7-7: Find Contacts action version bump is appropriate.Updating the version to
"0.0.8"aligns with the wider release; existing streaming implementation remains valid.components/trengo/actions/send-a-ticket-message/send-a-ticket-message.mjs (1)
5-5: Send A Ticket Message version bump is consistent.Raising the action version to
"0.0.2"is consistent with the Trengo package update; the existing props and run implementation remain coherent.components/trengo/actions/create-contact/create-contact.mjs (1)
6-6: Create Contact action version bump looks good.The version increment to
"0.0.8"matches the broader Trengo release and doesn’t affect the existing behavior.components/trengo/sources/ticket-reopened/ticket-reopened.mjs (1)
7-23: Ticket Reopened source version bump is appropriate.The source version change to
"0.0.5"is consistent with the rest of the Trengo updates. The existinggetMetaimplementation (ID/ts/summary) remains valid.components/trengo/actions/list-messages/list-messages.mjs (1)
8-8: Version bump only – behavior unchangedThe version metadata increment to
0.0.5is consistent with the rest of the Trengo actions and does not alter runtime behavior.components/trengo/actions/list-labels/list-labels.mjs (1)
8-8: List Labels action version bump looks goodIncrementing the version to
0.0.3aligns with the broader Trengo action updates and doesn’t affect behavior.components/trengo/actions/list-articles/list-articles.mjs (1)
7-7: List Articles action metadata-only changeThe version update to
0.0.6is purely metadata and keeps the existing list-articles behavior intact.components/trengo/actions/get-label/get-label.mjs (1)
7-7: Get Label action version increment is safeUpdating the version to
0.0.3is consistent with other Trengo actions and introduces no behavioral changes.components/trengo/actions/attach-label/attach-label.mjs (1)
7-7: Attach Label action version bump aligns with suiteThe version change to
0.0.3is metadata-only and keeps the attach-label behavior unchanged.components/trengo/actions/list-tickets/list-tickets.mjs (1)
8-8: List Tickets action version update is non-breakingThe version bump to
0.0.5matches other Trengo actions and does not modify the list-tickets behavior.components/trengo/sources/voice-call-recorded/voice-call-recorded.mjs (1)
7-7: Voice Call Recorded source version bump is fineRaising the version to
0.0.6is a metadata-only change; webhook handling and dedupe behavior are unchanged.components/trengo/actions/send-a-whatsapp-message-template/send-a-whatsapp-message-template.mjs (1)
7-7: Send WhatsApp Message Template action – version bump onlyThe version update to
0.0.8is consistent with related actions and doesn’t affect the existing validation or request logic.components/trengo/actions/send-a-team-chat-message/send-a-team-chat-message.mjs (1)
7-7: Version bump looks good.The version increment aligns with the package-level version bump to 0.6.0.
components/trengo/sources/phone-call-ended/phone-call-ended.mjs (1)
7-7: Version bump looks good.The version increment aligns with the package-level version bump to 0.6.0.
components/trengo/sources/phone-call-started/phone-call-started.mjs (1)
7-7: Version bump looks good.The version increment aligns with the package-level version bump to 0.6.0.
components/trengo/sources/new-inbound-message/new-inbound-message.mjs (1)
7-7: Version bump looks good.The version increment aligns with the package-level version bump to 0.6.0.
components/trengo/actions/send-a-message/send-a-message.mjs (1)
6-6: Version bump looks good.The version increment aligns with the package-level version bump to 0.6.0.
components/trengo/package.json (1)
3-3: Package version bump is appropriate.The minor version increment (0.5.0 → 0.6.0) correctly reflects the addition of new functionality (close ticket action) following semantic versioning conventions.
components/trengo/actions/log-a-voice-call/log-a-voice-call.mjs (1)
6-6: Version bump looks good.The version increment aligns with the package-level version bump to 0.6.0.
components/trengo/sources/ticket-label-added/ticket-label-added.mjs (1)
7-7: Version bump looks good.The version increment aligns with the package-level version bump to 0.6.0.
components/trengo/sources/ticket-closed/ticket-closed.mjs (1)
7-7: Version bump is appropriate and non-breakingPatch version increment for this source is fine and does not affect runtime behavior.
components/trengo/trengo.app.mjs (2)
211-227:ticketResultIdprop definition is consistent with existing patternsThe prop mirrors other ID props (pagination via
page + 1, mappingname→ label andid→ value) and cleanly delegates tolistTicketResults, so it should integrate well with the new action.
391-405: NewcloseTicket/listTicketResultshelpers align with the rest of the app surfaceBoth helpers correctly reuse
_makeRequest, match the existing naming conventions, and keep the interface minimal by passing throughticketIdand other config, so they’re easy to consume from actions.
|
Hi everyone, all test cases are passed! Ready for release! Test reports
|
WHY
Resolves #19171
Summary by CodeRabbit
New Features
Minor Updates
✏️ Tip: You can customize this high-level summary in your review settings.