Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed many Codacy vulnerability #975

Merged
merged 2 commits into from Jan 15, 2020
Merged

Fixed many Codacy vulnerability #975

merged 2 commits into from Jan 15, 2020

Conversation

@matteofabbri
Copy link

matteofabbri commented Jan 10, 2020

Still TBF: Refactoring of App and a better hashing than MD5

Matteo Fabbri
@tidyui

This comment has been minimized.

Copy link
Member

tidyui commented Jan 10, 2020

It will take me a while to go through this PR as there are 68 affected files, but I'll get back to you 😀

@tidyui

This comment has been minimized.

Copy link
Member

tidyui commented Jan 10, 2020

Thank you for your PR! I have added some comments with actions, see above!

Matteo Fabbri
@tidyui tidyui merged commit a509038 into PiranhaCMS:master Jan 15, 2020
2 of 6 checks passed
2 of 6 checks passed
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
LGTM analysis: C# Analysis failed (could not build the base commit (10ab80c))
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
LGTM analysis: JavaScript No code changes detected
Details
CodeFactor 1 issue fixed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.