Wind degrees precision / DarkSky compatibility

[oisact]

Minor issue here which did cause me issues in my iOS app. DarkSky API reported current wind direction (windDegrees) in whole integers. However your PirateWeather API is reporting windDegrees as a float with tenth of a degree precision. Tenth of a degree is surely far more precise than the actual accuracy of the data. I'm working around this server-side in my data processing to round it to an integer before my iOS app consumes it. This kind of issue can be common in very type-strict languages like Swift.

Just pointing this out if you are interested in the highest level compatibility with DarkSky.

[cloneofghosts]

I know there was talk about having an option to have the API round certain parameters but it never really went anywhere Pirate-Weather/pirate-weather-ha#29.

I definitely like having the extra precision that two decimal points give so maybe having a option to round certain parameters to whole numbers or maybe having a windBearingCardinal which displays the cardinal direction would also work?

[oisact]

I definitely like having the extra precision that two decimal points

My point is the underlying model and data are not accurate to that precision, so it's basically random noise / false data anything more accurate than a degree. To give an idea, both NOAA and the FAA require anemometers to be within 5 degrees accuracy. And that is for actual measurements! So having two decimals just means you have two orders of magnitude of precision that doesn't actually exist.

[cloneofghosts]

My point is the underlying model and data are not accurate to that precision, so it's basically random noise / false data anything more accurate than a degree. To give an idea, both NOAA and the FAA require anemometers to be within 5 degrees accuracy. And that is for actual measurements! So having two decimals just means you have two orders of magnitude of precision that doesn't actually exist.

Thanks for that info as I wasn't aware that it was that inaccurate. I went and checked other APIs to see if they rounded the degrees and all of them do.

If we're not actually losing anything by rounding it to a whole number then it makes sense to do so.

[github-actions]

There has been no activity on this issue for ninety days and unless you comment on the issue it will automatically close in seven days.

[cloneofghosts]

Friendly reminder to look into this issue and other rounding issues that are in issue #4 @alexander0042

[alexander0042]

This is a great use for the stale label- a real issue that's easily fixable! I'll take a look at it in conjunction with #4 now!

[alexander0042]

Ok, I think I've fixed all the rounding issues! To summarize:

• Precipitation intensity and accumulation are rounded to 4 digits
• Wind bearing is to the nearest whole number
• Everything else should be two digits

Let me know if notice any glitches, or if anything else should be different. This should also address #4 and #77

[cloneofghosts]

@alexander0042 I think their intent was to have windBearing have no decimal places where currently it is rounded to the nearest whole number but still has a decimal place "windBearing": 80.0,.

windSpeed is still rounded to 3 decimal places on currently "windSpeed": 18.274, and precipProbibility seems broken in the minutely section as the value is always 2:

"data": [
      {
        "time": 1689258960,
        "precipIntensity": 0.0,
        "precipProbability": 2,
        "precipIntensityError": 0.5,
        "precipType": "none"
      },

[alexander0042]

You have an amazing eye for this stuff! Fixed , fixed, and fixed!

[cloneofghosts]

Everything looks good now. Feel free to close.

[alexander0042]

Awesome! Each little fix makes this better, step by step