Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on Sudoku tutorial chapters 1-6 #164

Open
bvssvni opened this issue Jul 11, 2017 · 1 comment

Comments

@bvssvni
Copy link
Member

commented Jul 11, 2017

Chapter 1

  • Fixed wording

Chapter 2

  • Fixed wording

Chapter 3

  • Fixed wording

Chapter 4

  • "Set up objects and handle like this:" => "Set up objects and handle events:"
  • "gameboard_view.draw(&gameboard_controller.gameboard, &c, g);" => "gameboard_view.draw(&gameboard_controller, &c, g);" 2 places

Chapter 5

  • "if x >= 0.0 && x <= size && y >= 0.0 && y <= size {" => "if x >= 0.0 && x < size && y >= 0.0 && y < size {" This is a bug. Need to update code. Check the other chapters.

Chapter 6

  • "use graphics::character::CharacterCache;" Lack Rust syntax highlighting.
  • "import Transformed" => "import the trait Transformed" Add after code "The trait constraint CharacterCache<Texture = G::Texture>" makes sure that the texture type matches the type used by the graphics backend."
  • After code for drawing characters, add "let ch_y = pos[1] - character.top(); has a negative sign because the y-axis in font coordinates points upwards while the y-axis in drawing coordinates points downwards."
@bvssvni

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2017

I wonder if we should put line comments // NEW to show where you add code.

Alternative: // <---

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.