Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed scaling bug #149

Merged
merged 1 commit into from Nov 10, 2018

Conversation

@bvssvni
Copy link
Member

commented Nov 10, 2018

Closes #145

@bvssvni

This comment has been minimized.

Copy link
Member Author

commented Nov 10, 2018

@arnodb

This comment has been minimized.

Copy link

commented Nov 10, 2018

It looks like it's working well, perfect. Feel free to close #148 when this one is merged.

@0e4ef622

This comment has been minimized.

Copy link
Contributor

commented Nov 10, 2018

Looks good to me.

@bvssvni bvssvni merged commit 54f0e7d into PistonDevelopers:master Nov 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bvssvni bvssvni deleted the bvssvni:bug branch Nov 10, 2018

@0e4ef622 0e4ef622 referenced this pull request Nov 11, 2018

Closed

Fix dpi scaling #147

@0e4ef622

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2018

Actually I just noticed, shouldn't a Resize event give the new size in points? The docs don't say, and this code is returning the new size in physical pixels. And in the same vein, glutin should be able to handle all the dpi stuff and as I understand it, piston's "points" are equivalent to glutin's "logical pixels", so there really shouldn't be any dpi scaling in this library except for Window::draw_size.

@bvssvni

This comment has been minimized.

Copy link
Member Author

commented Nov 14, 2018

@0e4ef622 You're right.

@arnodb

This comment has been minimized.

Copy link

commented Nov 14, 2018

Interesting, I thought my app was asking for a window size in pixels but, after reading the doc Size is supposed to be in points and WindowSettings is asking for a Size. That means that the app should convert the resize events back to pixels (if eventually it contains points in the future) so that I can pass the pixels to the OpenGL calls. Do you confirm?

bvssvni added a commit to bvssvni/glutin_window that referenced this pull request Nov 14, 2018

@bvssvni bvssvni referenced this pull request Nov 14, 2018

Merged

Fix Resize bug #155

@bvssvni

This comment has been minimized.

Copy link
Member Author

commented Nov 14, 2018

@arnodb Yes, that's correct. Resize events is supposed to be in points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.