Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed scaling bug #149
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
arnodb
commented
Nov 10, 2018
|
It looks like it's working well, perfect. Feel free to close #148 when this one is merged. |
This comment has been minimized.
This comment has been minimized.
|
Looks good to me. |
bvssvni
merged commit 54f0e7d
into
PistonDevelopers:master
Nov 10, 2018
1 check passed
bvssvni
deleted the
bvssvni:bug
branch
Nov 10, 2018
bvssvni
referenced this pull request
Nov 12, 2018
Closed
Fix the resize factor according to glutin README. #148
This comment has been minimized.
This comment has been minimized.
|
Actually I just noticed, shouldn't a Resize event give the new size in points? The docs don't say, and this code is returning the new size in physical pixels. And in the same vein, glutin should be able to handle all the dpi stuff and as I understand it, piston's "points" are equivalent to glutin's "logical pixels", so there really shouldn't be any dpi scaling in this library except for Window::draw_size. |
This comment has been minimized.
This comment has been minimized.
|
@0e4ef622 You're right. |
This comment has been minimized.
This comment has been minimized.
arnodb
commented
Nov 14, 2018
•
|
Interesting, I thought my app was asking for a window size in pixels but, after reading the doc |
bvssvni
added a commit
to bvssvni/glutin_window
that referenced
this pull request
Nov 14, 2018
This comment has been minimized.
This comment has been minimized.
|
@arnodb Yes, that's correct. Resize events is supposed to be in points. |
bvssvni commentedNov 10, 2018
Closes #145