JPG overflow fix. Fixes #409 #412

Merged
merged 2 commits into from May 12, 2015

Conversation

Projects
None yet
2 participants
@pix64
Contributor

pix64 commented May 12, 2015

On release builds overflows are not checked, on debug builds they are causing Image to panic on certain JPGs. "wrapping_shl" is unstable and not available in Rust Beta so instead this checks if the shift is too large and just sets the value to 0 if it is.

@nwin

This comment has been minimized.

Show comment
Hide comment
@nwin

nwin May 12, 2015

Contributor

Great, thanks what a relieve!

Contributor

nwin commented May 12, 2015

Great, thanks what a relieve!

nwin added a commit that referenced this pull request May 12, 2015

@nwin nwin merged commit 85d0524 into PistonDevelopers:master May 12, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@waddlesplash waddlesplash referenced this pull request in servo/servo May 12, 2015

Closed

Switch to Piston's image library #3368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment