Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Adds ability to display an image in a window using sdl2 #298
Thanks for this - should be a very useful feature.
I won't have time to review this properly until the weekend, but I did try it out locally and one thing that surprised me was that I could only show one image at a time - is it easy to add support for showing multiple windows at the same time? (So that e.g. I can view the input image, some intermediate, and the result side by side.)
I would prefer to add the ability to create multiple image windows in another pull request. Having a way to display a single image is sufficient for some use cases and multiple windows satisfies another use case.
Also if you have mac testing it on that would be useful because I can only test on ubuntu and windows 10 for the time being.
theotherphil left a comment
I've mentioned a few things that needs resolving and left a couple of other comments.
It would be nice to add something to examples/ showing how to use this function, but I'm happy to merge without an example.