New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cross-Correlation to Template Matching #311

Merged
merged 4 commits into from Feb 2, 2019

Conversation

Projects
None yet
2 participants
@JonBoyleCoding
Copy link
Contributor

JonBoyleCoding commented Feb 1, 2019

I added Cross-Correlation as a method for template matching based on the equations here: https://docs.opencv.org/3.4/de/da9/tutorial_template_matching.html

@theotherphil

This comment has been minimized.

Copy link
Member

theotherphil commented Feb 1, 2019

Looks good, thanks. It would be nice to have a new test for this function, and to add a comment explaining that (unlike SSE) higher values are better.

@JonBoyleCoding

This comment has been minimized.

Copy link
Contributor Author

JonBoyleCoding commented Feb 1, 2019

Ok, I'll work on getting a test in!

@JonBoyleCoding

This comment has been minimized.

Copy link
Contributor Author

JonBoyleCoding commented Feb 2, 2019

I've added tests based on the ones that are currently there, and I checked the expected result with OpenCV 4 to make sure it was correct.

@theotherphil theotherphil merged commit 51fced8 into PistonDevelopers:master Feb 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@theotherphil

This comment has been minimized.

Copy link
Member

theotherphil commented Feb 2, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment