-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable CI for repos that break on stable #1050
Comments
In the future, I would personally choose "break later" if "break now" means not being able to build on stable. I realise that the next working stable release is only a week away and this really isn't a big deal, but I just wanted to mention that I think we should take our commitment to building consistently on stable very seriously (so far, I've managed to avoid having to use an unstable build of Rust since |
I was not aware of this breakage until it was too late, so I decided to continue based on too little information. It is quite complicated now since there are many things that need to be tested at once, and because of the demanding recent upgrades I was not in good enough shape to avoid all mistakes. The mistake I did was not account for information I did not know at that moment. Normally this would not happen, but because of many complicated reasons, this error sneaked it. There is no change in the commitment to building on stable. Next time we'll wait fixing the warnings until it works on stable. |
Does anybody have a link to the relevant rust issue for this? |
@Ryman I updated the top comment with link to the Rust PR. |
Oh I didn't realise it was a mistake! No problem at all sir, these things happen 😄 |
Rust 1.8 is released. Closing. |
You should update the note here now that it's out. |
There is an upcoming breaking change in Rust for
pub extern crate
. See rust-lang/rust#31362. Currently, this is a warning on beta and nightly releases. We can choose to break stuff now or later, so we will break stuff now.People are recommended to use beta or nightly until next Rust stable release (1.8).
CI will be disabled temporarily where this is a problem, and turn back on next Rust stable release.
Here is a list of repos where CI is disabled:
The text was updated successfully, but these errors were encountered: