Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `WindowSettings::draw_size` #939

Closed
bvssvni opened this issue Jul 25, 2015 · 8 comments

Comments

@bvssvni
Copy link
Member

commented Jul 25, 2015

See https://www.reddit.com/r/rust_gamedev/comments/3ejcy2/using_piston_how_can_i_configure_a_set_game/

Currently the window back-end decides the resolution of the frame buffer.

@bvssvni

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2015

One problem is that PistonWindow automatically resizes the frame buffer.

Probably need some way to tell whether one should resize. Could be AdvancedWindow::should_resize_draw_buffer.

@bvssvni

This comment has been minimized.

Copy link
Member Author

commented Jul 26, 2015

The Iterator is implemented for PistonWindow with the Window constraint, so it needs to be Window::should_resize_draw_buffer.

@bvssvni

This comment has been minimized.

Copy link
Member Author

commented Jul 26, 2015

Doesn't seem like Glutin support this.

@bvssvni

This comment has been minimized.

Copy link
Member Author

commented Jul 26, 2015

rust-sdl2 doesn't support this either, it seems.

@bvssvni

This comment has been minimized.

Copy link
Member Author

commented Jul 26, 2015

It seems that window mode automatically sets the frame buffer. The only way to fix the resolution is to open the window in full screen.

@bvssvni

This comment has been minimized.

Copy link
Member Author

commented Jul 26, 2015

It remains to figure out whether PistonWindow should resize the buffer or not.

@bvssvni

This comment has been minimized.

Copy link
Member Author

commented Jul 26, 2015

I believe this is a viewport/transformation issue. It might be possible to do this without needing a setting.

@bvssvni

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2015

I haven't managed to find a good solution for this. Reopen if you have better ideas.

@bvssvni bvssvni closed this Jul 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.