New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SDL2 style controller hats #1227

Merged
merged 2 commits into from May 11, 2018

Conversation

Projects
None yet
2 participants
@Heinrich-F
Contributor

Heinrich-F commented May 10, 2018

This commit added a few things related to more fully support X-box controllers via the sdl2_window backend (related to the issue #206 on the sdl2_window repository [1] . I used the stuff introduced here to fix issue #206 there, you should be able to see that in my fork of sdl2_window. If/When this PR gets accepted I'll open a PR for that as well)

[1] PistonDevelopers/sdl2_window#206

@bvssvni

This comment has been minimized.

Member

bvssvni commented May 10, 2018

Looks good to me.

@bvssvni

This comment has been minimized.

Member

bvssvni commented May 10, 2018

I think you linked to the wrong issue in the description.

@bvssvni

This comment has been minimized.

Member

bvssvni commented May 11, 2018

Merging.

@bvssvni bvssvni merged commit 14046db into PistonDevelopers:master May 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bvssvni

This comment has been minimized.

Member

bvssvni commented May 11, 2018

Thanks!

I'll publish a new version.

@Heinrich-F

This comment has been minimized.

Contributor

Heinrich-F commented May 11, 2018

I think you linked to the wrong issue in the description.

Well, it should reference the problem in sdl2_window that says that Xbox one controllers don't send d-pad events. I had to make the changes here in order to make a fix for that in sdl2_window, that I think fits somewhat with how the rest of it works.
Thanks for merging, I will open the PR for the problem in sdl2_window shortly.

@bvssvni

This comment has been minimized.

Member

bvssvni commented May 18, 2018

@Heinrich-F Remember to make the PR in sdl2_window. Thanks for contributing!

@Heinrich-F

This comment has been minimized.

Contributor

Heinrich-F commented May 22, 2018

I was actually quite glad to be able to contribute. First time contributing to some open source project.
The PR on sdl2_window should be open already.

@bvssvni

This comment has been minimized.

Member

bvssvni commented May 22, 2018

@Heinrich-F If that's your first time, I'm impressed. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment