Add FileDrag to the Input enum#1269
Merged
bvssvni merged 1 commit intoPistonDevelopers:masterfrom Feb 6, 2019
kaikalii:master
Merged
Add FileDrag to the Input enum#1269bvssvni merged 1 commit intoPistonDevelopers:masterfrom kaikalii:master
FileDrag to the Input enum#1269bvssvni merged 1 commit intoPistonDevelopers:masterfrom
kaikalii:master
Conversation
Member
|
Merging. |
Member
|
Thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted piston to be able to hand file drag events, so I added an enum called
FileDragwhich contains variants that mirror the file drag events of glutin. I added this enum as the only field of a new variant ofInput,Input::FileDrag. I was going to add it to theMotionenum instead, but file dragging events include aPathBuf, which is notCopy.