Skip to content

findKeys functionality #18

Merged
merged 13 commits into from Jan 10, 2013

2 participants

@JohnMcLear JohnMcLear merged commit bad0a4f into Pita:develop Jan 10, 2013
@JohnMcLear
Collaborator

This will require a module version bump and push to npm to make it "work".. Just FYI.. I will try to get that done asap

@JohnMcLear
Collaborator

Can you please create some docs / edit the readme page. Thanks

@spcsser
spcsser commented Jan 10, 2013

Thanks for the quick reply. Added some comments, modified the readme, hope this suffices. Do I have to issue a new pull request?

@JohnMcLear
Collaborator

Hrm, didn't see the readme changes?

If you can put a pull request in for the readme that'd be good :) I merged the code.

@spcsser
spcsser commented Jan 10, 2013

Sorry, I meant that I added them then. Anyway - opened a new request: #23

Edit: Already pulled - that's fast ;)

@JohnMcLear JohnMcLear referenced this pull request in ether/etherpad-lite Jan 21, 2013
Closed

Object has no method 'findKeys' #1381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.