Mysql findKeys bug fix #26

Merged
merged 5 commits into from Jan 15, 2013

Conversation

Projects
None yet
3 participants
Contributor

spcsser commented Jan 15, 2013

Sorry to bother again, but the mysql findKeys function did not work proper. Fixed tests to catch this and fixed the function.

Collaborator

JohnMcLear commented Jan 15, 2013

Please read contributing guidelines. Your trying to merge into master, we don't allow that.

Collaborator

JohnMcLear commented Jan 15, 2013

Oh it's UeberDB, should be fine to merge to master then :)

JohnMcLear added a commit that referenced this pull request Jan 15, 2013

@JohnMcLear JohnMcLear merged commit 0d1b141 into Pita:master Jan 15, 2013

Contributor

spcsser commented Jan 15, 2013

Yeah, sorry about that - I just saw it after opening the request.

Collaborator

JohnMcLear commented on 6d6f220 Feb 13, 2013

This actually breaks MySQL!

Collaborator

JohnMcLear replied Feb 13, 2013

I fixed it on latest master, dunno how it got past testing though!!

Contributor

spcsser commented Feb 17, 2013

Just came to test it - your fix in master does not work for me. You need to replace the asterisk with the percentage sign to make the sql work and then push it to the params - just adding it as param should not do the trick.

I'm just a bit confused how it actually passed the test in the current version...

Collaborator

JohnMcLear commented Feb 17, 2013

Hrm, can you issue a pull request with what you find works and I will test. Please :)

Contributor

spcsser commented Feb 17, 2013

Sure thing - coming right up ;)

Collaborator

JohnMcLear commented Feb 17, 2013

@eldiddio when this lands can you please test it on your installation?

Contributor

spcsser commented Feb 17, 2013

Here it is - #35

Tested this on my install and it seems to work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment