Fix info button on first page display #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @plegall , this PR is rather straightforward and fixes a real bug with the plugin. |
The info button's target was set in update_picture(), which is called when the picture changes. As a consequence, the button was inactive before the first image change. Fix this by setting an initial href value for the button when loading the page. Fixes Piwigo#23.
|
While I see you're reviewing other PRs here, another ping @plegall . I've just added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The info button's target was set in update_picture(), which is called when the picture changes. As a consequence, the button was inactive before the first image change.
Fix this by setting an initial href value for the button when loading the page.