Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[security] quick search and criteria display #559

Closed
plegall opened this issue Nov 29, 2016 · 6 comments
Closed

[security] quick search and criteria display #559

plegall opened this issue Nov 29, 2016 · 6 comments
Milestone

Comments

@plegall
Copy link
Member

@plegall plegall commented Nov 29, 2016

We need to sanitize search criteria used in quick search before displaying on search_rules.php page.

Reported by @BlueTower

@plegall
Copy link
Member Author

@plegall plegall commented Nov 29, 2016

related to #548

@plegall plegall closed this in 7b2315a Nov 29, 2016
@fgeek
Copy link

@fgeek fgeek commented Dec 22, 2016

CVE-2016-9751 identifier has been assigned for this vulnerability.

@BlueTower
Copy link

@BlueTower BlueTower commented Feb 8, 2017

Hello @plegall -

I believe this issue needs to reopened. I am still able to execute a payload on (http://piwigo.org/demo/search_rules.php?search_id=38739) using a payload such as:

<svg onload=alert&#40;1&#41>

Suggestions?

@fgeek
Copy link

@fgeek fgeek commented Oct 7, 2017

@plegall Any comments? Can you take a new look and fix this in 2.9.3?

@plegall plegall added this to the 2.9.3 milestone Oct 7, 2017
@plegall plegall reopened this Oct 7, 2017
@TallGuysFreeADMIN
Copy link
Contributor

@TallGuysFreeADMIN TallGuysFreeADMIN commented Oct 14, 2017

Can anyone reproduce? I've tested for XSS many times (not just in piwigo), and the piwigo.org link by bluetower isn't showing any alert. Tested in Firefox, where XSS should work.

@plegall
Copy link
Member Author

@plegall plegall commented Feb 21, 2018

I can't reproduce neither. I close this already closed bug.

@plegall plegall closed this Feb 21, 2018
@plegall plegall modified the milestones: 2.9.3, 2.8.4 Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.