Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace include file='comment_list.tpl' #603

Open
flop25 opened this Issue Jan 12, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@flop25
Copy link
Member

flop25 commented Jan 12, 2017

so comment_list can be replaced via template extension or extensions
No HTML changes just tpl and php

@flop25 flop25 self-assigned this Jan 12, 2017

@flop25 flop25 closed this in 47164bc Sep 1, 2017

@flop25 flop25 added this to the 2.10.0beta1 milestone Sep 1, 2017

@flop25

This comment has been minimized.

Copy link
Member Author

flop25 commented Sep 1, 2017

I have assigned this to 2.10 since the tpl code changed a bit
awaiting CP

@plegall

This comment has been minimized.

Copy link
Member

plegall commented Jul 24, 2018

Can we have more details on this issue? Why do we need this change? What does it imply? Do themes and plugins developers need to know about this change?

@modus75

This comment has been minimized.

Copy link
Contributor

modus75 commented Jul 24, 2018

@plegall

This comment has been minimized.

Copy link
Member

plegall commented Jul 24, 2018

OK @modus75 but at the beginning, @flop25 what does this issue tries to fix? Is there a problem with the {include} directive in Smarty? (I have no idea, I'm trying to understand the origin of this issue)

@flop25

This comment has been minimized.

Copy link
Member Author

flop25 commented Jul 24, 2018

@plegall

This comment has been minimized.

Copy link
Member

plegall commented Jul 24, 2018

OK, I get it :-)

@flop25

This comment has been minimized.

Copy link
Member Author

flop25 commented Jul 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.