New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP notice when changing admin page's theme #747

Closed
ghost opened this Issue Aug 27, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@ghost

ghost commented Aug 27, 2017

Hi,

I got this notice in my Apache error log when switching the theme of the admin page :

[Sun Aug 27 16:49:21.736536 2017] [proxy_fcgi:error] [pid 30996:tid 121883778676480] [client 2001:db8:3849::42] AH01071: Got error 'PHP message: PHP Notice:  Only variables should be passed by reference in /path/admin.php on line 65\n', referer: https://piwigo.example.org/path/admin.php?change_theme=1

I'm running Apache 2.4.25 with php7.0-fpm and PHP 7.0.22. Piwigo is up-to-date

Don't look like a big issue, but then again I'm lacking PHP knowledge and it pollutes my error log :)

@plegall plegall added this to the 2.9.2 milestone Sep 19, 2017

@plegall plegall self-assigned this Sep 19, 2017

@plegall

This comment has been minimized.

Show comment
Hide comment
@plegall

plegall Sep 19, 2017

Member

Fixed on #774 commit 943ab9d by @MaximeBOURMAUD

Member

plegall commented Sep 19, 2017

Fixed on #774 commit 943ab9d by @MaximeBOURMAUD

@plegall plegall closed this Sep 19, 2017

@plegall

This comment has been minimized.

Show comment
Hide comment
@plegall

plegall Sep 19, 2017

Member

... and cherry-picked in 2.9 6530720

Member

plegall commented Sep 19, 2017

... and cherry-picked in 2.9 6530720

daniele-athome pushed a commit to daniele-athome/Piwigo that referenced this issue Sep 12, 2018

Issue/747 php notice when changing admin page theme (Piwigo#774)
* FixesPiwigo#747 Only variables should be passed by reference

* Fixes syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment