Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add twitter cards and Open Graph on pages #786

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@tcitworld
Copy link

commented Sep 27, 2017

Adds Open Graph Protocol tags and Twitter Cards support to the main template. If we are on a picture page, we also have it's preview.

Fix #737

Add twitter and Open Graph on pages
Signed-off-by: Thomas Citharel <tcit@tcit.fr>

@tcitworld tcitworld changed the title Add twitter and Open Graph on pages Add twitter cards and Open Graph on pages Sep 27, 2017

@TallGuysFreeADMIN

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2017

I think this is better as an extension. Many people, including myself, choose Piwigo for simplicity.

Piwigo galleries might be:
Private, locally hosted, or on an intranet.

If anyone is using HTML in their page descriptions, this isn't going to work nicely.

Having the twitter site as @Piwigo is very unacceptable.

Twitter Cards is already an extension.

@flop25

This comment has been minimized.

Copy link
Member

commented Oct 8, 2017

of course we won't implement twitter or any website specific html
only opengraph tags could be added
as it this commit will never be accepted

@tcitworld tcitworld closed this Mar 17, 2019

@tcitworld tcitworld deleted the tcitworld:ogp-twitter-graph branch Mar 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.