Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order by the field(s) used to find duplicates #910

Merged
merged 1 commit into from Jul 17, 2019

Conversation

@samwilson
Copy link
Contributor

commented Aug 10, 2018

When searching for duplicates, also sort the results by the
fields used to find the duplicates.

Refs #860

@samwilson

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2018

@plegall I'm not sure if this is the best place for this order-by code, but it seemed possibly appropriate. What do you think?

@samwilson samwilson force-pushed the samwilson:order-by-dupe-field branch from 6890c7b to 06bd73f Aug 10, 2018

@samwilson samwilson force-pushed the samwilson:order-by-dupe-field branch from 06bd73f to 018e14b Aug 13, 2018

@samwilson

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2018

Does anyone have a chance to look at this? Thanks!

@samwilson

This comment has been minimized.

Copy link
Contributor Author

commented Oct 16, 2018

Gentle bump.

(I'm processing a bunch of duplicates from an import and would love to have this patch merged, if it's suitable.)

@samwilson

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2019

I'd be happy to improve this patch if required.

@samwilson

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2019

@plegall this PR is still valid for the current master branch. I think it'd be good to be able to sort duplicate photos side-by-side. (Sorry if I keep hassling. Feel free to close this if you're not interested.)

Order by the field(s) used to find duplicates
When searching for duplicates, also sort the results by the
fields used to find the duplicates.

@samwilson samwilson force-pushed the samwilson:order-by-dupe-field branch from 018e14b to 7f6b60d Jul 15, 2019

@plegall plegall merged commit 05fb7aa into Piwigo:master Jul 17, 2019

@plegall plegall self-requested a review Jul 17, 2019

@plegall plegall self-assigned this Jul 17, 2019

@plegall plegall added this to the 2.10.0RC1 milestone Jul 17, 2019

@plegall

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

I fully agree with this PR, very nice small improvement :-)

@samwilson samwilson deleted the samwilson:order-by-dupe-field branch Jul 17, 2019

@samwilson

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.