Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDL cmx_3600 adapter does not support unnamed markers. #594

Open
elabrosseRodeofx opened this issue Sep 27, 2019 · 1 comment

Comments

@elabrosseRodeofx
Copy link
Contributor

commented Sep 27, 2019

This is the content of an cmx_3600 EDL exported from Avid media composer:

TITLE:   Untitled Sequence.01 
FCM: NON-DROP FRAME
001  103043_0 V     C        01:00:00:00 01:00:08:10 01:00:00:00 01:00:08:10 
* FROM CLIP NAME:  MYMEDIA.MOV 
* LOC: 01:00:02:01 RED

As you can see the marker does not have a name

Current behavior:

>>> timeline = otio.adapters.read_from_file('markers.edl')
>>> list(timeline.each_clip())[0].markers
[]

Expected behavior:

>>> timeline = otio.adapters.read_from_file('markers.edl')
>>> list(timeline.each_clip())[0].markers
[
otio.schema.Marker(name='', marked_range=otio.opentime.TimeRange(start_time=otio.opentime.RationalTime(value=86449, rate=24), duration=otio.opentime.RationalTime(value=0, rate=1)), metadata={'cmx_3600': {'color': u'RED'}})
]

From what I saw this is due to the regular expression that matches locator comments in cmx_3600.py line 457.
Should OpenTimelineIO support unnamed markers ? I feel like it should since some editing systems are able to export unnamed markers. Let me know what you think !

My corporation is waiting for confirmation that our CLA was received. We will submit a PR as soon as possible.

@elabrosseRodeofx

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2019

Made a PR:

#598

jminor added a commit that referenced this issue Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.