New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use system Python; CI tests all python versions #127

Merged
merged 4 commits into from Jul 11, 2017

Conversation

Projects
None yet
3 participants
@mikemahony
Collaborator

mikemahony commented Jul 8, 2017

Travis CI will test all Python versions, including nightly builds.

@ssteinbach

This comment has been minimized.

Show comment
Hide comment
@ssteinbach

ssteinbach Jul 10, 2017

Member

After chewing on this all weekend, can we reduce the list to python2.7 and 3.5? Since those are the two versions we're advertising support for, I think those are the only two versions we should really focus on testing. Also, @reinecke do you see any problems with losing the explicit 3.5 test targets and falling back on system python? Or is that an issue for your development workflow?

Member

ssteinbach commented Jul 10, 2017

After chewing on this all weekend, can we reduce the list to python2.7 and 3.5? Since those are the two versions we're advertising support for, I think those are the only two versions we should really focus on testing. Also, @reinecke do you see any problems with losing the explicit 3.5 test targets and falling back on system python? Or is that an issue for your development workflow?

@ssteinbach ssteinbach requested review from reinecke and ssteinbach Jul 10, 2017

@ssteinbach ssteinbach added this to the Public Beta 5 milestone Jul 10, 2017

@reinecke

This comment has been minimized.

Show comment
Hide comment
@reinecke

reinecke Jul 10, 2017

Collaborator

This sounds great to me! I'm using virtualenv-based workflows entirely now, so this actually makes sure when I run the tests they'll happen for the env I'm working in.

I had actually been feeling guilt over introducing the hard-coded version test targets the other day, it never felt quite right to me.

Collaborator

reinecke commented Jul 10, 2017

This sounds great to me! I'm using virtualenv-based workflows entirely now, so this actually makes sure when I run the tests they'll happen for the env I'm working in.

I had actually been feeling guilt over introducing the hard-coded version test targets the other day, it never felt quite right to me.

@ssteinbach

My only requested change is reducing the number of tested python versions to the two supported ones. Thanks!

Show outdated Hide outdated .travis.yml
- "3.3"
- "3.4"
- "3.5"
- "3.5-dev"

This comment has been minimized.

@ssteinbach

ssteinbach Jul 10, 2017

Member

Cool, I think we can narrow this list down to 2.7 and the 3.5 variants though, since those are the versions we explicitly support.

@ssteinbach

ssteinbach Jul 10, 2017

Member

Cool, I think we can narrow this list down to 2.7 and the 3.5 variants though, since those are the versions we explicitly support.

This comment has been minimized.

@mikemahony

mikemahony Jul 11, 2017

Collaborator

Ok. Slimmed to 2.7 and 3.5.

@mikemahony

mikemahony Jul 11, 2017

Collaborator

Ok. Slimmed to 2.7 and 3.5.

Show outdated Hide outdated README.md
@@ -1,6 +1,8 @@
OpenTimelineIO
==============
[![Build Status](https://www.travis-ci.com/PixarAnimationStudios/OpenTimelineIO.svg?token=XCu1kiDYTaUqGyY883AU&branch=master)](https://www.travis-ci.com/PixarAnimationStudios/OpenTimelineIO)

This comment has been minimized.

@ssteinbach

ssteinbach Jul 10, 2017

Member

Awesome! Thanks for adding this!

@ssteinbach

ssteinbach Jul 10, 2017

Member

Awesome! Thanks for adding this!

This comment has been minimized.

@mikemahony

mikemahony Jul 11, 2017

Collaborator

Swapped this out (we're still private) for the python versions badge.

@mikemahony

mikemahony Jul 11, 2017

Collaborator

Swapped this out (we're still private) for the python versions badge.

@ssteinbach ssteinbach merged commit 07fd4d7 into PixarAnimationStudios:master Jul 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment