New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling of 'serializable' #144

Merged
merged 3 commits into from Aug 10, 2017

Conversation

Projects
None yet
3 participants
@boredstiff
Collaborator

boredstiff commented Aug 9, 2017

Before development and integration of OTIO gets too far along, I thought we might want to fix the spelling of this. Feel free to reject and keep it as it currently is, it was only a quick refactor. I ran all tests and everything is passing.

Fix spelling of 'serializable'
Before development and integration of OTIO gets too far along, I thought we might want to fix the spelling of this. Feel free to reject and keep it as it currently is, it was only a quick refactor. I ran all tests and everything is passing.
@jminor

This comment has been minimized.

Show comment
Hide comment
@jminor

jminor Aug 9, 2017

Collaborator

Oops, thanks for catching that.

Since SerializableCollection.1 also changed, we'll need to add code to handle old OTIO files that have SerializeableCollection.1 objects in them. We previously renamed Filler to Gap and you can see how we handled that here: #122 The essential piece was core.register_type(Gap, "Filler")

Also, we could consider renaming SerializableCollection to just Collection...

Collaborator

jminor commented Aug 9, 2017

Oops, thanks for catching that.

Since SerializableCollection.1 also changed, we'll need to add code to handle old OTIO files that have SerializeableCollection.1 objects in them. We previously renamed Filler to Gap and you can see how we handled that here: #122 The essential piece was core.register_type(Gap, "Filler")

Also, we could consider renaming SerializableCollection to just Collection...

@jminor

This all looks fine, we just need a call to core.register_type so that old OTIO files with the misspelling in them will still be readable.

@boredstiff

This comment has been minimized.

Show comment
Hide comment
@boredstiff

boredstiff Aug 10, 2017

Collaborator

The Travis repository is still private, so I'm guessing that what failed was the linter.

Collaborator

boredstiff commented Aug 10, 2017

The Travis repository is still private, so I'm guessing that what failed was the linter.

@ssteinbach

This comment has been minimized.

Show comment
Hide comment
@ssteinbach

ssteinbach Aug 10, 2017

Member

Whoops. We'll flip the switch on making that public. Sorry about that! See #146

Member

ssteinbach commented Aug 10, 2017

Whoops. We'll flip the switch on making that public. Sorry about that! See #146

@jminor

jminor approved these changes Aug 10, 2017

Great. Thanks for making that change.

@jminor jminor merged commit 83bfb77 into PixarAnimationStudios:master Aug 10, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment