Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
GeneratorReference implementation. #148
Adds support for a otio.schema.GeneratorReference class, and sketches out a SMPTEBars version of that class. Also adds support for this in the RV adapter.
Reposted with the public fork (was #132)
changed the title from
Aug 10, 2017
referenced this pull request
Aug 26, 2017
This looks totally reasonable to me. I like the idea of using an enum for generator kind, It will encourage some schema unification around the generator types commonly used (flat color, smpte bars, timecode overlay, etc.)
I'd be curious to know what kinds of generators people are encountering so we can try this approach against them, but it seems pretty solid to me.
I guess the only concern I would have with this, is that using a generic "parameters" field leaves it quite open to what you put in there.
I'm generally in favor of using Enums as much as possible in the API, strings are error prone. Especialy since the underlying implementation will use a readable text string so that its easy to add new enums. If we use strings they should be backed up by defines for common usages.