New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burnin adapter (second attempt) #167

Merged
merged 7 commits into from Oct 5, 2017

Conversation

Projects
None yet
3 participants
@repsac
Collaborator

repsac commented Oct 5, 2017

Removed enums.
Constants are now global (as opposed to a class namespace).
Updating the MIT license with preamble.

@repsac

This comment has been minimized.

Show comment
Hide comment
@repsac

repsac Oct 5, 2017

Collaborator

Test server doesn't have PIL. That is going to make this difficult.

ImportError: No module named PIL

Collaborator

repsac commented Oct 5, 2017

Test server doesn't have PIL. That is going to make this difficult.

ImportError: No module named PIL

repsac added some commits Oct 5, 2017

Ading Pillow (PIP) to travis' pip install
Moved bundling comment to LICENSE.txt
Improved box drawing for background
Added second unittest for burins without backgrounds
Merge pull request #2 from repsac/burnin
Adding Pillow (PIP) to travis' pip install
@repsac

This comment has been minimized.

Show comment
Hide comment
@repsac

repsac Oct 5, 2017

Collaborator

The system font thing is going to be a pain. On my mac it uses Menlo, and even if I could figure out the system font to use on travis it is going to throw the box dimensions (for the x position) off when calculating the right alignments.

Yeah at this point I am not sure how to get this through.

Collaborator

repsac commented Oct 5, 2017

The system font thing is going to be a pain. On my mac it uses Menlo, and even if I could figure out the system font to use on travis it is going to throw the box dimensions (for the x position) off when calculating the right alignments.

Yeah at this point I am not sure how to get this through.

@jminor

This comment has been minimized.

Show comment
Hide comment
@jminor

jminor Oct 5, 2017

Collaborator

You can either just drop the test (honestly that would be fine),
or maybe bundle a specific font so it is consistent?
Something like this: https://fonts.google.com/specimen/Open+Sans maybe?

Collaborator

jminor commented Oct 5, 2017

You can either just drop the test (honestly that would be fine),
or maybe bundle a specific font so it is consistent?
Something like this: https://fonts.google.com/specimen/Open+Sans maybe?

adjusting the ffmpeg_burnins lib to not parse a system font unless us…
…ing RIGHT alignments

this should get around the test case issues
@repsac

This comment has been minimized.

Show comment
Hide comment
@repsac

repsac Oct 5, 2017

Collaborator

I have an update that only parses the system font when using 'right' alignments. As long as we don't use those in the tests this may work. Still poking at it.

Collaborator

repsac commented Oct 5, 2017

I have an update that only parses the system font when using 'right' alignments. As long as we don't use those in the tests this may work. Still poking at it.

Merge pull request #3 from repsac/burnin
adjusting the ffmpeg_burnins lib to not parse a system font
@jminor

jminor approved these changes Oct 5, 2017

@jminor

This comment has been minimized.

Show comment
Hide comment
@jminor

jminor Oct 5, 2017

Collaborator

Ed, this looks great, the tests all pass now, and we have your CLA on file. Is there anything else you want to change before we accept it?

Collaborator

jminor commented Oct 5, 2017

Ed, this looks great, the tests all pass now, and we have your CLA on file. Is there anything else you want to change before we accept it?

@repsac

This comment has been minimized.

Show comment
Hide comment
@repsac

repsac Oct 5, 2017

Collaborator

Nope, that is all I can think of for now.

Collaborator

repsac commented Oct 5, 2017

Nope, that is all I can think of for now.

@ssteinbach ssteinbach added this to the Public Beta 6 milestone Oct 5, 2017

@jminor jminor merged commit 9e7eeda into PixarAnimationStudios:master Oct 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jminor

This comment has been minimized.

Show comment
Hide comment
@jminor

jminor Oct 5, 2017

Collaborator

Accepted. Thanks Ed! This will be super handy.

Collaborator

jminor commented Oct 5, 2017

Accepted. Thanks Ed! This will be super handy.

@repsac

This comment has been minimized.

Show comment
Hide comment
@repsac

repsac Oct 5, 2017

Collaborator

Awesome. Will be interesting to see how it appeals to users.

Collaborator

repsac commented Oct 5, 2017

Awesome. Will be interesting to see how it appeals to users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment