New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an empty string for a locator comment if the marker name is None #172

Merged
merged 1 commit into from Oct 25, 2017

Conversation

Projects
None yet
2 participants
@michaeljefferies
Collaborator

michaeljefferies commented Oct 18, 2017

No description provided.

@jminor

This comment has been minimized.

Show comment
Hide comment
@jminor

jminor Oct 18, 2017

Collaborator

Thanks @michaeljefferies! This change looks great.

It may seem like overkill for a small change like this, but we'll need a signed CLA from you or your company in order to accept your change. See here for details: https://github.com/PixarAnimationStudios/OpenTimelineIO/wiki/Contributing

Collaborator

jminor commented Oct 18, 2017

Thanks @michaeljefferies! This change looks great.

It may seem like overkill for a small change like this, but we'll need a signed CLA from you or your company in order to accept your change. See here for details: https://github.com/PixarAnimationStudios/OpenTimelineIO/wiki/Contributing

@michaeljefferies

This comment has been minimized.

Show comment
Hide comment
@michaeljefferies

michaeljefferies Oct 25, 2017

Collaborator

Sorry, finally got around to filling out the CLA and sent it in.

Collaborator

michaeljefferies commented Oct 25, 2017

Sorry, finally got around to filling out the CLA and sent it in.

@jminor jminor merged commit eb653a3 into PixarAnimationStudios:master Oct 25, 2017

@jminor

This comment has been minimized.

Show comment
Hide comment
@jminor

jminor Oct 25, 2017

Collaborator

Great! Thanks.

Collaborator

jminor commented Oct 25, 2017

Great! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment