New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor media reference #204

Merged
merged 5 commits into from Jan 11, 2018

Conversation

Projects
None yet
2 participants
@ssteinbach
Member

ssteinbach commented Jan 10, 2018

This is to clear room to make GeneratorReference a child class of MediaReference.

  • Move otio.media_reference -> otio.core.media_reference
  • Rename media_reference.External to schema.ExternalReference
  • Move MissingReference into Schema.

@ssteinbach ssteinbach added the bug label Jan 10, 2018

@ssteinbach ssteinbach added this to the Public Beta 7 milestone Jan 10, 2018

@ssteinbach ssteinbach requested a review from jminor Jan 10, 2018

@jminor

jminor approved these changes Jan 10, 2018

This looks great. I know the rename of an existing class will be annoying to people, but it is better to do that now rather than later, and this feels much cleaner now.

@ssteinbach ssteinbach merged commit 520d527 into PixarAnimationStudios:master Jan 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment