New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPi updates (#239) #241

Merged
merged 2 commits into from Apr 2, 2018

Conversation

Projects
None yet
4 participants
@swallitsch
Contributor

swallitsch commented Apr 2, 2018

This PR does some groundwork to make #239 (Put OTIO on PyPi) possible:

  • Add a setup.cfg file which points to the README.md file for the description
  • Update setup.py with:
    • Classifiers
    • License
    • Keywords
    • install_requires placeholder
    • support for running the main test suite with python setup.py test

In addition, it includes a commit to add the Pycharm .idea/ folder to .gitignore. This commit can be removed from the PR if desired.

@swallitsch swallitsch referenced this pull request Apr 2, 2018

Closed

Put OTIO on PyPi #239

@@ -0,0 +1,2 @@
[metadata]
description-file = README.md

This comment has been minimized.

@mikemahony

mikemahony Apr 2, 2018

Collaborator

Looks like we're missing a newline here.

This comment has been minimized.

@swallitsch

swallitsch Apr 2, 2018

Contributor

Added a newline.

@ssteinbach

I just had one question about python versions, but this looks great! thanks for your submission!

'License :: Other/Proprietary License',
'Programming Language :: Python :: 2',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3',

This comment has been minimized.

@ssteinbach

ssteinbach Apr 2, 2018

Member

I'm not sure how the tagging is supposed to be set up. Officially we support python 2.7 and 3.5, those are the only two versions we test against. It probably works in the versions you list, but I'm not sure how strict this is meant to be.

This comment has been minimized.

@swallitsch

swallitsch Apr 2, 2018

Contributor

I'll remove the other specified versions of 3 from the list.

Expand setup.py with additional metadata (#239)
PyPi requires additional metadata such as classifiers.
Configure setup.py to run the core tests with 'python setup.py test'
Add setup.cfg for pointing pypi to the README
@ssteinbach

This comment has been minimized.

Member

ssteinbach commented Apr 2, 2018

Perfect, thanks again.

@ssteinbach ssteinbach merged commit d490ddb into PixarAnimationStudios:master Apr 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reinecke

This comment has been minimized.

Collaborator

reinecke commented Apr 3, 2018

This is great +1

@swallitsch swallitsch deleted the swallitsch:pypi_updates branch Apr 10, 2018

@ssteinbach ssteinbach added this to the Public Beta 8 milestone Apr 10, 2018

jminor added a commit to jminor/OpenTimelineIO that referenced this pull request Apr 11, 2018

PyPi updates (PixarAnimationStudios#239) (PixarAnimationStudios#241)
* Add PyCharm .idea/ folder to .gitignore
* Expand setup.py with additional metadata (PixarAnimationStudios#239)
* PyPi requires additional metadata such as classifiers.
* Configure setup.py to run the core tests with 'python setup.py test'
* Add setup.cfg for pointing pypi to the README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment