Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build for Python 3.6 #291

Merged
merged 3 commits into from Jul 30, 2018

Conversation

Projects
None yet
4 participants
@boredstiff
Copy link
Collaborator

boredstiff commented Jul 23, 2018

I've been running Python 3.6 for OTIO since last year and have never run into a problem with it and since vfxplatform states we should be targeting 3.6, I figured we should all just skip forward.

Here is my test.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 23, 2018

Codecov Report

Merging #291 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #291   +/-   ##
=======================================
  Coverage   91.34%   91.34%           
=======================================
  Files          49       49           
  Lines        4354     4354           
=======================================
  Hits         3977     3977           
  Misses        377      377

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b35e37...ad90253. Read the comment docs.

@reinecke

This comment has been minimized.

Copy link
Collaborator

reinecke commented Jul 24, 2018

+1
We’ve been on 3.6 for quite a while now. We haven’t run into any issues in our usage.

@jminor jminor added this to the Public Beta 9 milestone Jul 24, 2018

@jminor

This comment has been minimized.

Copy link
Collaborator

jminor commented Jul 30, 2018

Can you update the badge in the README.md to show 3.6 also?
I think the URL format is this: https://img.shields.io/badge/python-2.7%2C%203.5%2C%203.6-blue.svg

Alex Widener added some commits Jul 30, 2018

Alex Widener
Alex Widener
@boredstiff

This comment has been minimized.

Copy link
Collaborator Author

boredstiff commented Jul 30, 2018

Changed @jminor

@jminor

jminor approved these changes Jul 30, 2018

@jminor jminor merged commit 19d45ad into PixarAnimationStudios:master Jul 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jminor

This comment has been minimized.

Copy link
Collaborator

jminor commented Jul 30, 2018

Thanks!

@boredstiff

This comment has been minimized.

Copy link
Collaborator Author

boredstiff commented Jul 30, 2018

:( Wrong lines were edited and now there are two sets of badges. I am not a fan of using Github's editor to do changes. Submitting separate PR now.

ssteinbach added a commit to ssteinbach/OpenTimelineIO that referenced this pull request Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.