Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PySide2 to setup.py under view key #293

Merged
merged 1 commit into from Jul 24, 2018
Merged

Add PySide2 to setup.py under view key #293

merged 1 commit into from Jul 24, 2018

Conversation

boredstiff
Copy link
Contributor

PySide2 is on PyPi as of a week ago.

This adds the PySide2 dependency underneath the 'view' key in extra_requires, as discussed in #269 (comment)

Updated the README with instructions as well.

@codecov-io
Copy link

Codecov Report

Merging #293 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #293   +/-   ##
=======================================
  Coverage   90.92%   90.92%           
=======================================
  Files          49       49           
  Lines        4352     4352           
=======================================
  Hits         3957     3957           
  Misses        395      395

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aae64de...3a85871. Read the comment docs.

@boredstiff
Copy link
Contributor Author

(otio) C:\dev\OpenTimelineIO>pip install -e .[view]
Obtaining file:///C:/dev/OpenTimelineIO
Collecting PySide2==5.11 (from OpenTimelineIO==0.8.0.dev1)
  Downloading https://files.pythonhosted.org/packages/fe/4e/06a26bb928fabb6374d85532c8bdeee1c17a64e683f5104d9698fa84c98e/PySide2-5.11.0-5.11.0-cp35.cp36-none-win_amd64.whl (129.5MB)
    100% |████████████████████████████████| 129.5MB 218kB/s
Installing collected packages: PySide2, OpenTimelineIO
  Running setup.py develop for OpenTimelineIO
Successfully installed OpenTimelineIO PySide2-5.11.0

@jminor jminor added this to the Public Beta 8 milestone Jul 24, 2018
Copy link
Collaborator

@jminor jminor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jminor jminor merged commit 1fa2bed into AcademySoftwareFoundation:master Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants