Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs revealed by or related to code coverage. #298

Merged
merged 6 commits into from Jul 27, 2018

Conversation

Projects
None yet
3 participants
@ssteinbach
Copy link
Member

ssteinbach commented Jul 26, 2018

Found some missnamed exceptions thanks to improving the coverage score. Also omitted files that are not run during unit tests on travis since they won't qualify for code coverage.

@ssteinbach ssteinbach added this to the Public Beta 9 milestone Jul 26, 2018

@ssteinbach ssteinbach requested a review from jminor Jul 26, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 26, 2018

Codecov Report

Merging #298 into master will increase coverage by 0.41%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
+ Coverage   90.92%   91.34%   +0.41%     
==========================================
  Files          49       49              
  Lines        4352     4354       +2     
==========================================
+ Hits         3957     3977      +20     
+ Misses        395      377      -18
Impacted Files Coverage Δ
opentimelineio/exceptions.py 100% <100%> (ø) ⬆️
opentimelineio/plugins/manifest.py 92.5% <100%> (+7.5%) ⬆️
opentimelineio/adapters/__init__.py 89.13% <0%> (+2.17%) ⬆️
opentimelineio/schema/serializable_collection.py 100% <0%> (+10%) ⬆️
opentimelineio/media_linker.py 97.56% <0%> (+17.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6650017...0fb52d7. Read the comment docs.

ssteinbach added some commits Jul 26, 2018

result = otio.plugins.manifest.load_manifest()
self.assertEqual(result.media_linkers[0].name, "example")
os.remove(fpath)
os.removedirs(dirpath)

This comment has been minimized.

@jminor

jminor Jul 26, 2018

Collaborator

If you put the os.remove... stuff inside a finally: block, it will clean up even if the assert fails.

@jminor

jminor approved these changes Jul 27, 2018

@ssteinbach ssteinbach merged commit 5b35e37 into PixarAnimationStudios:master Jul 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ssteinbach ssteinbach deleted the ssteinbach:coverage_bump branch Jul 27, 2018

ssteinbach added a commit to ssteinbach/OpenTimelineIO that referenced this pull request Sep 17, 2018

Fix bugs revealed by or related to code coverage. (PixarAnimationStud…
…ios#298)

* Omit things that don't get tested from code coverage.
* Add tests for error cases in the media linker and fix some bugs.
* Add a unit test for search path resolution.
* More unit tests in serializable collection.
* Rewrite unit test to use 'with' statement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.