New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcuts for OTIOview #302

Merged
merged 5 commits into from Aug 10, 2018

Conversation

Projects
7 participants
@bonpix
Collaborator

bonpix commented Aug 3, 2018

Addresses issue #278

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 3, 2018

Codecov Report

Merging #302 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
+ Coverage   90.86%   90.89%   +0.02%     
==========================================
  Files          53       53              
  Lines        4489     4512      +23     
==========================================
+ Hits         4079     4101      +22     
- Misses        410      411       +1
Impacted Files Coverage Δ
...elineio_contrib/adapters/tests/test_aaf_adapter.py 96.99% <0%> (+0.06%) ⬆️
...neio_contrib/adapters/advanced_authoring_format.py 91.07% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1e53e5...09c1b3a. Read the comment docs.

codecov-io commented Aug 3, 2018

Codecov Report

Merging #302 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
+ Coverage   90.86%   90.89%   +0.02%     
==========================================
  Files          53       53              
  Lines        4489     4512      +23     
==========================================
+ Hits         4079     4101      +22     
- Misses        410      411       +1
Impacted Files Coverage Δ
...elineio_contrib/adapters/tests/test_aaf_adapter.py 96.99% <0%> (+0.06%) ⬆️
...neio_contrib/adapters/advanced_authoring_format.py 91.07% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1e53e5...09c1b3a. Read the comment docs.

@ssteinbach ssteinbach added this to the Public Beta 9 milestone Aug 3, 2018

@ssteinbach ssteinbach requested a review from jminor Aug 3, 2018

@ssteinbach

Looks great, thanks!

@ssteinbach ssteinbach added this to To do in OTIO View via automation Aug 3, 2018

@boredstiff

This comment has been minimized.

Show comment
Hide comment
@boredstiff

boredstiff Aug 8, 2018

Collaborator

I would recommend changing the camelCasing to fit with the snake_casing of the rest of the library.

Collaborator

boredstiff commented Aug 8, 2018

I would recommend changing the camelCasing to fit with the snake_casing of the rest of the library.

@bonpix

This comment has been minimized.

Show comment
Hide comment
@bonpix

bonpix Aug 9, 2018

Collaborator

Newest version cleans up the code and adds function of going into nested item when the "Enter" key is pressed. Also most Markers and Transitions react to the arrow keys now, with the exception of the Markers without parentItems at the very top.

Items are also centered when selected.

Collaborator

bonpix commented Aug 9, 2018

Newest version cleans up the code and adds function of going into nested item when the "Enter" key is pressed. Also most Markers and Transitions react to the arrow keys now, with the exception of the Markers without parentItems at the very top.

Items are also centered when selected.

@jminor

I like the _get_left/right/up/down_item methods! I just have a couple of tiny requests. The rest looks great.

Show outdated Hide outdated opentimelineview/timeline_widget.py
Show outdated Hide outdated opentimelineview/timeline_widget.py

OTIO View automation moved this from To do to In progress Aug 9, 2018

@jminor

jminor approved these changes Aug 9, 2018

Thanks. This looks ready to me :)

@jminor jminor merged commit 6f15035 into PixarAnimationStudios:master Aug 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

OTIO View automation moved this from In progress to Done Aug 10, 2018

ssteinbach added a commit to ssteinbach/OpenTimelineIO that referenced this pull request Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment