New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guard if pkg_resources is not found. #314

Merged
merged 1 commit into from Sep 7, 2018

Conversation

Projects
None yet
3 participants
@ssteinbach
Member

ssteinbach commented Aug 23, 2018

Its possible for extern plugins (in particular, RV's py-interp) to not have pkg_resources on the python path. This should be ok, since it shouldn't need to access any plugins in order to write out a valid RV file.

@ssteinbach ssteinbach requested a review from reinecke Aug 23, 2018

@ssteinbach ssteinbach added this to the Public Beta 9 milestone Aug 23, 2018

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 23, 2018

Codecov Report

Merging #314 into master will decrease coverage by 0.03%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
- Coverage   90.89%   90.85%   -0.04%     
==========================================
  Files          53       53              
  Lines        4512     4516       +4     
==========================================
+ Hits         4101     4103       +2     
- Misses        411      413       +2
Impacted Files Coverage Δ
opentimelineio/plugins/manifest.py 90.47% <71.42%> (-2.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f15035...c5f79e3. Read the comment docs.

codecov-io commented Aug 23, 2018

Codecov Report

Merging #314 into master will decrease coverage by 0.03%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
- Coverage   90.89%   90.85%   -0.04%     
==========================================
  Files          53       53              
  Lines        4512     4516       +4     
==========================================
+ Hits         4101     4103       +2     
- Misses        411      413       +2
Impacted Files Coverage Δ
opentimelineio/plugins/manifest.py 90.47% <71.42%> (-2.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f15035...c5f79e3. Read the comment docs.

@jminor

jminor approved these changes Sep 7, 2018

@jminor jminor merged commit c334cba into PixarAnimationStudios:master Sep 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

ssteinbach added a commit to ssteinbach/OpenTimelineIO that referenced this pull request Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment