New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode #321

Merged
merged 3 commits into from Sep 29, 2018

Conversation

Projects
4 participants
@boredstiff
Collaborator

boredstiff commented Sep 7, 2018

Closes #311

Went with as minimal of an approach as possible.

screen shot 2018-09-06 at 9 12 04 pm

Open to change requests.

@boredstiff boredstiff changed the title from Switch otioview to have a dark mode to Dark Mode Sep 7, 2018

@ssteinbach ssteinbach requested a review from bonpix Sep 7, 2018

@bonpix

Thanks boredstiff! The dark scheme is a little dark, so the scroll indicators on the right and bottom are a little hard to find; can we add some contrast to that?

Thanks for the stylesheet; that's going to help with GUI modifications later on =)

@ssteinbach ssteinbach added this to the Public Beta 9 milestone Sep 7, 2018

@ssteinbach

This comment has been minimized.

Show comment
Hide comment
@ssteinbach

ssteinbach Sep 24, 2018

Member

Really small annoying request, but can you also update the screenshot in the readme with the new color scheme? Thanks!

Member

ssteinbach commented Sep 24, 2018

Really small annoying request, but can you also update the screenshot in the readme with the new color scheme? Thanks!

@boredstiff

This comment has been minimized.

Show comment
Hide comment
@boredstiff

boredstiff Sep 26, 2018

Collaborator

Where would you like the image? It currently points to an image in the wiki, which I don't have access to edit.

You could optionally just change the image at this address: https://github.com/PixarAnimationStudios/OpenTimelineIO/wiki/images/otioview.png

to be this image

screen shot 2018-09-25 at 7 57 03 pm

And you wouldn't have to update anything. However, once #312 is merged into master, and the wiki isn't updated anymore, you can just use docs/_static and store the image in there.

Collaborator

boredstiff commented Sep 26, 2018

Where would you like the image? It currently points to an image in the wiki, which I don't have access to edit.

You could optionally just change the image at this address: https://github.com/PixarAnimationStudios/OpenTimelineIO/wiki/images/otioview.png

to be this image

screen shot 2018-09-25 at 7 57 03 pm

And you wouldn't have to update anything. However, once #312 is merged into master, and the wiki isn't updated anymore, you can just use docs/_static and store the image in there.

@jminor

jminor approved these changes Sep 29, 2018

@jminor jminor added this to To do in OTIO View via automation Sep 29, 2018

@jminor jminor merged commit bb0a380 into PixarAnimationStudios:master Sep 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

OTIO View automation moved this from To do to Done Sep 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment