New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `manifest_from_string` #339

Merged
merged 9 commits into from Oct 11, 2018

Conversation

Projects
None yet
3 participants
@ssteinbach
Member

ssteinbach commented Oct 10, 2018

A unit test was calling a function that didn't exist - this adds that function and makes the unit test work.

@ssteinbach ssteinbach requested a review from reinecke Oct 10, 2018

@ssteinbach ssteinbach added this to the Public Beta 9 milestone Oct 10, 2018

@ssteinbach ssteinbach added the bug label Oct 10, 2018

@jminor jminor requested review from peachey and removed request for peachey Oct 10, 2018

@ssteinbach ssteinbach requested a review from peachey Oct 10, 2018

@peachey

Looks pretty good to me. But I'm slightly troubled by the use of file as a substitute for a JSON file name. For instance, in the utils.py remove_manifest function, manifest.source_files are removed. Could that end up removing a python source file?

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 10, 2018

Codecov Report

Merging #339 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
+ Coverage   73.78%   73.81%   +0.03%     
==========================================
  Files          59       59              
  Lines        5340     5351      +11     
==========================================
+ Hits         3940     3950      +10     
- Misses       1400     1401       +1
Impacted Files Coverage Δ
opentimelineio/plugins/manifest.py 91.48% <100%> (+1.01%) ⬆️
opentimelineio/adapters/cmx_3600.py 91.56% <0%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b6aace...9efd079. Read the comment docs.

codecov-io commented Oct 10, 2018

Codecov Report

Merging #339 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
+ Coverage   73.78%   73.81%   +0.03%     
==========================================
  Files          59       59              
  Lines        5340     5351      +11     
==========================================
+ Hits         3940     3950      +10     
- Misses       1400     1401       +1
Impacted Files Coverage Δ
opentimelineio/plugins/manifest.py 91.48% <100%> (+1.01%) ⬆️
opentimelineio/adapters/cmx_3600.py 91.56% <0%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b6aace...9efd079. Read the comment docs.

@ssteinbach ssteinbach merged commit 9fc2195 into PixarAnimationStudios:master Oct 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ssteinbach ssteinbach deleted the ssteinbach:manifest_from_string_impl branch Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment