New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More examples & documentation #344

Merged
merged 11 commits into from Oct 23, 2018

Conversation

Projects
None yet
4 participants
@jminor
Collaborator

jminor commented Oct 17, 2018

No description provided.

@jminor jminor requested a review from ssteinbach Oct 17, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Oct 17, 2018

Codecov Report

Merging #344 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #344   +/-   ##
=======================================
  Coverage   73.82%   73.82%           
=======================================
  Files          59       59           
  Lines        5352     5352           
=======================================
  Hits         3951     3951           
  Misses       1401     1401
Impacted Files Coverage Δ
opentimelineio/core/item.py 97.29% <ø> (ø) ⬆️
opentimelineio/schema/marker.py 94.59% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c10fd9...ce99dcf. Read the comment docs.

This will return the same thing as `trimmed_range()` but also takes any
adjacent Transitions into account. For example, a Clip that is trimmed to
end at frame 10, but is followed by a symmetric 10 frame cross-dissolve,
will have a `visible_range()` that ends at frame 15.

This comment has been minimized.

@avrata

avrata Oct 17, 2018

Collaborator

Should this say "ends at frame 20"? I thought visible_range took into account the entire length of the dissolve (ie all frames shown, even if only a little).

This comment has been minimized.

@avrata

avrata Oct 17, 2018

Collaborator

Oh, nevermind. I think I understand in this case the 10 frame dissolve overlaps -5 frames back into the trimmed_range.

This comment has been minimized.

@jminor

jminor Oct 17, 2018

Collaborator

I'll clarify that. I meant the dissolve was 5 frames on either side of the cut.

@ssteinbach

Thanks! Some small notes on wording.

Overview
----------
A Timeline and all of the Tracks and Stacks with in it work together to place

This comment has been minimized.

@ssteinbach

ssteinbach Oct 17, 2018

Member
Suggested change Beta
A Timeline and all of the Tracks and Stacks with in it work together to place
A Timeline and all of the Tracks and Stacks it contains work together to place
- Ranges within the Clip and its media:
- `clip.available_range()`

This comment has been minimized.

@ssteinbach

ssteinbach Oct 17, 2018

Member
Suggested change Beta
- `clip.available_range()`
- `Clip.available_range()`

I think the class is upper case and the module is lower case?

is not a hard constraint. Some use cases will intentionally ask for
a Clip that is longer (or starts earlier) than the available media as a way
to request that new media (a newly animated take, or newly recorded audio)
be made to fill the requested `source_range`.

This comment has been minimized.

@ssteinbach

ssteinbach Oct 17, 2018

Member

You may want to note that source_range is in the coordinate frame of the available_range. In other words, if the available_range is from frame 5 to 20, and the source range is from 0 to 10, that doesn't mean frame 5-15 in the available range, but rather frames 0 to 10, of which only 5 are in the available range (which may indicate a problem).

This comment has been minimized.

@jminor

jminor Oct 17, 2018

Collaborator

How about if I add a note to each of them indicating whether the range is in the "Clip's coordinate frame" or the "parent's coordinate frame".

This comment has been minimized.

@ssteinbach

ssteinbach Oct 17, 2018

Member

Do we define what that coordinate frame is anywhere? Or how it relates to the coordinate frame of the media reference? Regardless, sounds good.

This comment has been minimized.

@ssteinbach

ssteinbach Oct 17, 2018

Member

That stuff is also just looking ahead to when we start back in on the time stuff.

@jminor jminor merged commit a13284e into PixarAnimationStudios:master Oct 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment