New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable medialinker from commandline #355

Merged
merged 2 commits into from Nov 6, 2018

Conversation

Projects
None yet
4 participants
@ssteinbach
Member

ssteinbach commented Oct 31, 2018

Adds commandline arguments to disable the media linker (or specify it) to:

  • otiocat
  • otioconvert
  • otioview

@ssteinbach ssteinbach requested review from avrata and peachey Oct 31, 2018

@ssteinbach ssteinbach added this to the Public Beta 9 milestone Oct 31, 2018

@avrata

avrata approved these changes Oct 31, 2018

Looks good. I know there is a future plan to cut down on duplicated code here, but this helps expose this option now.

@codecov-io

This comment has been minimized.

codecov-io commented Oct 31, 2018

Codecov Report

Merging #355 into master will decrease coverage by 0.05%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
- Coverage   74.18%   74.13%   -0.06%     
==========================================
  Files          63       63              
  Lines        5454     5462       +8     
==========================================
+ Hits         4046     4049       +3     
- Misses       1408     1413       +5
Impacted Files Coverage Δ
opentimelineio/console/otioconvert.py 66.66% <50%> (-3.61%) ⬇️
opentimelineio/console/otiocat.py 81.81% <66.66%> (-11.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6727d21...e836bb3. Read the comment docs.

@jminor

jminor approved these changes Nov 6, 2018

@ssteinbach ssteinbach merged commit 4fd29f5 into PixarAnimationStudios:master Nov 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ssteinbach ssteinbach deleted the ssteinbach:disable_medialinker_from_commandline branch Nov 6, 2018

alatdneg added a commit to alatdneg/OpenTimelineIO that referenced this pull request Nov 13, 2018

Disable medialinker from commandline (PixarAnimationStudios#355)
* Add commandline arguments to set the media linker to none to otiocat and convert.
* Add support to otioview for setting or disabling the media linker.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment