Bugfixes: Issue 320, 338, and 349 (biggest feature: constructors copy values) #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also a few more places where metadata needed to be copied - Item uses the Composable base class constructor argument passing
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
==========================================
+ Coverage 74.24% 74.29% +0.05%
==========================================
Files 63 63
Lines 5466 5466
==========================================
+ Hits 4058 4061 +3
+ Misses 1408 1405 -3
Continue to review full report at Codecov.
|
|
Good to see this change exposed some programming errors in the adaptors! |
alatdneg
reviewed
Nov 6, 2018
alatdneg
pushed a commit
to alatdneg/OpenTimelineIO
that referenced
this pull request
Nov 13, 2018
… values) (AcademySoftwareFoundation#359) * Ensure that upgrade functions are sorted. * Remove unneccesary check from deserialize_from_string * Make a copy of the environment in the rv adapter. * Enforce copying arguments to items. * Ensure that end_time_inclusive returns a copy. * Copy arguments to TimeRange and TimeTransform. * Use the "super" syntax for calling the parent constructor. * cleaned up extended_by. * Gate deepcopy with if rather than 'or' * Add unit tests for coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should address:
TimeRange.end_time_inclusivereturns a copy