New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AAF unit tests in travis. #370

Merged
merged 4 commits into from Nov 12, 2018

Conversation

Projects
None yet
3 participants
@ssteinbach
Member

ssteinbach commented Nov 9, 2018

Rejiggered the travis/tox configuration:

  • PyAAF installation happens in tox now, rather than travis. Because tox builds itself a virtualenv, this makes it easier for tox to do the right thing. Note that this only works for linux, because it has explicit paths to released files from github. If we could get PyAAF from pip, this would be simpler.
  • Travis tells tox which environment to run
  • Adjusted the import name on Pillow, which seems to have changed in recent versions of the library.
  • Added the mock library as a dependency (needed for several unit tests in core).
  • Makes tests run with verbose printout so that its easier to see what/why things get skipped.
  • Removed Python 3.7 testing from Tox (it wasn't in Travis anyways). If someone wants this, we should add it to both.

@ssteinbach ssteinbach added this to the Public Beta 10 milestone Nov 9, 2018

@ssteinbach ssteinbach requested review from jminor and boredstiff Nov 9, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Nov 9, 2018

Codecov Report

Merging #370 into master will increase coverage by 13.07%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #370       +/-   ##
===========================================
+ Coverage   74.34%   87.42%   +13.07%     
===========================================
  Files          63       63               
  Lines        5497     5497               
===========================================
+ Hits         4087     4806      +719     
+ Misses       1410      691      -719
Impacted Files Coverage Δ
...ntimelineio_contrib/adapters/tests/test_burnins.py 92.85% <100%> (+47.61%) ⬆️
opentimelineio/adapters/adapter.py 93.84% <0%> (-3.08%) ⬇️
opentimelineio_contrib/adapters/ffmpeg_burnins.py 76.39% <0%> (+76.39%) ⬆️
opentimelineio_contrib/adapters/burnins.py 90.9% <0%> (+79.54%) ⬆️
...elineio_contrib/adapters/tests/test_aaf_adapter.py 97.08% <0%> (+82.84%) ⬆️
...neio_contrib/adapters/advanced_authoring_format.py 91.59% <0%> (+91.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fec780c...27e3e88. Read the comment docs.

@jminor

jminor approved these changes Nov 12, 2018

@jminor jminor merged commit e1b4b45 into PixarAnimationStudios:master Nov 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

alatdneg added a commit to alatdneg/OpenTimelineIO that referenced this pull request Nov 13, 2018

Add support for AAF unit tests in travis. (PixarAnimationStudios#370)
* Fix dependencies to include pyaaf on linux.
* Make tests print in verbose mode so that its easier to see what gets skipped.
* Remove python37 since we aren't supporting it yet.
* Only run unit tests once.

flavienliger pushed a commit to flavienliger/OpenTimelineIO that referenced this pull request Nov 14, 2018

Add support for AAF unit tests in travis. (PixarAnimationStudios#370)
* Fix dependencies to include pyaaf on linux.
* Make tests print in verbose mode so that its easier to see what gets skipped.
* Remove python37 since we aren't supporting it yet.
* Only run unit tests once.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment