New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide deserialization methods of SerizableObject #386

Merged
merged 2 commits into from Nov 27, 2018

Conversation

Projects
3 participants
@ssteinbach
Member

ssteinbach commented Nov 20, 2018

We exposed the data dictionary (really the backing of SerializableObject), but since that is likely to change in the C++ version, this hides that. We're also hiding the .update() method, since it only seems to be used by internal implementation details that are also likely to change in the C++ version.

ssteinbach added some commits Nov 20, 2018

hide the data member of SerializableObject
- expose it on unknown schema instead.

@ssteinbach ssteinbach added this to the Public Beta 10 milestone Nov 20, 2018

@ssteinbach ssteinbach requested a review from jminor Nov 20, 2018

@ssteinbach ssteinbach added this to To Do in C++ API via automation Nov 20, 2018

@ssteinbach ssteinbach requested review from reinecke and davidbaraff Nov 20, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Nov 20, 2018

Codecov Report

Merging #386 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
+ Coverage   87.42%   87.42%   +<.01%     
==========================================
  Files          63       63              
  Lines        5533     5535       +2     
==========================================
+ Hits         4837     4839       +2     
  Misses        696      696
Impacted Files Coverage Δ
opentimelineio/core/type_registry.py 100% <100%> (ø) ⬆️
opentimelineio/core/serializable_object.py 91.37% <100%> (ø) ⬆️
opentimelineio/core/composition.py 94.35% <100%> (ø) ⬆️
opentimelineio/core/unknown_schema.py 100% <100%> (ø) ⬆️
opentimelineio/core/json_serializer.py 96.82% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ad32e...d2726bb. Read the comment docs.

@ssteinbach ssteinbach moved this from To Do to In Progress in C++ API Nov 21, 2018

@jminor

jminor approved these changes Nov 27, 2018

@jminor jminor merged commit 938f158 into PixarAnimationStudios:master Nov 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

C++ API automation moved this from In Progress to Done Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment