New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better dependency reporting for `pip` and `setuptools` #397

Merged
merged 7 commits into from Dec 7, 2018

Conversation

Projects
None yet
5 participants
@ssteinbach
Copy link
Member

ssteinbach commented Dec 6, 2018

We depend on relatively modern features inside the pip and setuptools libraries. Ironically, pip and setuptools don't provide great tools for catching this and reporting this.

  • Require pip version of at least 6.0
  • Require setuptools version of at least 20.5.0
  • Also make the dev dependencies floating (>= rather than pinned to a specific version ==)

Definitely open to comments on this. Is this a harsh requirement on folks? VFX Platform doesn't specify a pip or setuptools version, but it probably should.

@ssteinbach ssteinbach added this to the Public Beta 10 milestone Dec 6, 2018

@ssteinbach ssteinbach requested review from reinecke and boredstiff Dec 6, 2018

@davidbaraff

This comment has been minimized.

Copy link
Collaborator

davidbaraff commented Dec 6, 2018

@ssteinbach

This comment has been minimized.

Copy link
Member

ssteinbach commented Dec 6, 2018

Do we have a minimum cmake version? Could it be bumped up somewhat (into the 3’s?)

VFX Platform doesn't specify one... so I think we can pick whichever version we want. Looks like cmake has an internal command for managing its version:
https://cmake.org/cmake/help/v3.0/command/cmake_minimum_required.html

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 6, 2018

Codecov Report

Merging #397 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #397   +/-   ##
=======================================
  Coverage   87.05%   87.05%           
=======================================
  Files          63       63           
  Lines        5569     5569           
=======================================
  Hits         4848     4848           
  Misses        721      721

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc762bc...3c3a956. Read the comment docs.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 6, 2018

Codecov Report

Merging #397 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #397   +/-   ##
=======================================
  Coverage   87.05%   87.05%           
=======================================
  Files          63       63           
  Lines        5569     5569           
=======================================
  Hits         4848     4848           
  Misses        721      721

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc762bc...2628f8f. Read the comment docs.

@reinecke
Copy link
Collaborator

reinecke left a comment

Just a couple small things, I like these kinds of changes that help the "unboxing" experience a lot!

Show resolved Hide resolved setup.py
Show resolved Hide resolved setup.py
Show resolved Hide resolved setup.py Outdated

ssteinbach added some commits Dec 6, 2018

@jminor jminor merged commit bb60a6f into PixarAnimationStudios:master Dec 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ssteinbach ssteinbach referenced this pull request Jan 8, 2019

Closed

Can no longer build #324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment