New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test and fix for trimmed_range_in_parent when the item is trimmed out #401

Merged
merged 1 commit into from Dec 14, 2018

Conversation

Projects
None yet
3 participants
@ssteinbach
Copy link
Member

ssteinbach commented Dec 14, 2018

There was a bug in trimmed_range_in_parent that was causing a crash when the item was trimmed out of the parent. Now it correctly returns None and has a unit test for this.

@ssteinbach ssteinbach added the bug label Dec 14, 2018

@ssteinbach ssteinbach added this to the Public Beta 10 milestone Dec 14, 2018

@ssteinbach ssteinbach requested a review from jminor Dec 14, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 14, 2018

Codecov Report

Merging #401 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #401   +/-   ##
=======================================
  Coverage   87.07%   87.07%           
=======================================
  Files          63       63           
  Lines        5580     5580           
=======================================
  Hits         4859     4859           
  Misses        721      721
Impacted Files Coverage Δ
opentimelineio/core/composition.py 94.35% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74d45be...9976022. Read the comment docs.

@jminor

jminor approved these changes Dec 14, 2018

@jminor jminor merged commit 68ab344 into PixarAnimationStudios:master Dec 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment