New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for hook manifest issue #403

Merged
merged 3 commits into from Dec 19, 2018

Conversation

Projects
None yet
4 participants
@timlehr
Copy link
Contributor

timlehr commented Dec 18, 2018

Hi guys,

I had trouble getting the automatic hook calls to work. After digging through the code, I realized that some parts of the manifest class are missing code to keep track of parsed hooks / hook_scripts. I also added a missing hook to the tutorial.

timlehr added some commits Dec 18, 2018

- Fix: wrong type for "hooks"
- Fix: _json_path is not set for hook_scripts
- Fix: manifest extend() does not include hooks / hook_scripts
- Fix: added missing hook to tutorial sample code
- Fix: mismatching file name in tutorial example
@ssteinbach

This comment has been minimized.

Copy link
Member

ssteinbach commented Dec 19, 2018

Hi @timlehr! Thanks for catching this. It looks like the linter is failing in CI - you can check that locally with:
pip install -e . \[dev]
and then:
make lint

Or you can look at the log in the CI - looks like one of the lines is too long.

But the change looks good! Good catch!

@ssteinbach ssteinbach added this to the Public Beta 10 milestone Dec 19, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 19, 2018

Codecov Report

Merging #403 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
+ Coverage   86.91%   86.92%   +<.01%     
==========================================
  Files          63       63              
  Lines        5600     5604       +4     
==========================================
+ Hits         4867     4871       +4     
  Misses        733      733
Impacted Files Coverage Δ
opentimelineio/plugins/manifest.py 91.15% <100%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68ab344...7b07023. Read the comment docs.

@jminor jminor requested a review from ssteinbach Dec 19, 2018

@jminor

This comment has been minimized.

Copy link
Collaborator

jminor commented Dec 19, 2018

Thanks @timlehr ! In order to accept this, we will need a CLA from you. Here are the details: https://opentimelineio.readthedocs.io/en/latest/tutorials/contributing.html

@ssteinbach ssteinbach merged commit 8dcde4e into PixarAnimationStudios:master Dec 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ssteinbach

This comment has been minimized.

Copy link
Member

ssteinbach commented Dec 19, 2018

Thanks Tim!

timlehr added a commit to scarif-tools/OpenTimelineIO that referenced this pull request Dec 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment