Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruler - fix bug #456

Merged
merged 2 commits into from Mar 14, 2019

Conversation

Projects
3 participants
@tdervieux
Copy link
Collaborator

tdervieux commented Mar 13, 2019

  • Ruler.map_to_time_space methods now use item.trimmed_range() instead of relying on item.source_range.start_time which might not exist.
  • Adjust Ruler.map_to_time_space to show the correct last frame number (it was offset by +1 before)
    -Modify Ruler.init to order the items per track based on their start_frame. Before I was wrongly relying on track.childItems to return the items in the order they were created.
  • Initialize the nametuple self._bounder_data in Ruler.init rather than instancing it on each call of Ruler.map_to_time_space. This was slowing down the execution.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 13, 2019

Codecov Report

Merging #456 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #456   +/-   ##
=======================================
  Coverage   87.21%   87.21%           
=======================================
  Files          67       67           
  Lines        6819     6819           
=======================================
  Hits         5947     5947           
  Misses        872      872

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 291fda6...d35e2ab. Read the comment docs.

@ssteinbach ssteinbach added this to the Public Beta 10 milestone Mar 13, 2019

@ssteinbach ssteinbach added this to To do in OTIO View via automation Mar 13, 2019

OTIO View automation moved this from To do to In progress Mar 14, 2019

@ssteinbach ssteinbach merged commit 2cafadd into PixarAnimationStudios:master Mar 14, 2019

OTIO View automation moved this from In progress to Done Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.