Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested fix for #476 #488

Merged
merged 3 commits into from Apr 12, 2019

Conversation

Projects
None yet
4 participants
@apetrynet
Copy link
Contributor

apetrynet commented Apr 12, 2019

Hey!
This PR should produce the result @reinecke is after in #476

When passing an NDF timecode with a DF frame Rate to opentime.from_timecode calculation respects the NDF TC and does not remove frames.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 12, 2019

Codecov Report

Merging #488 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
+ Coverage   88.23%   88.23%   +<.01%     
==========================================
  Files          68       68              
  Lines        6900     6901       +1     
==========================================
+ Hits         6088     6089       +1     
  Misses        812      812
Impacted Files Coverage Δ
opentimelineio/opentime.py 92% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 878c67f...127b21d. Read the comment docs.

@ssteinbach ssteinbach requested a review from reinecke Apr 12, 2019

@reinecke
Copy link
Collaborator

reinecke left a comment

Looks great to me!

@ssteinbach ssteinbach added this to the Public Beta 10 milestone Apr 12, 2019

Show resolved Hide resolved opentimelineio/opentime.py Outdated
@ssteinbach
Copy link
Member

ssteinbach left a comment

Looks great, just one small note.

@ssteinbach ssteinbach merged commit 09091d0 into PixarAnimationStudios:master Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.