Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more elements and XMLs without libraries #515

Merged

Conversation

Projects
None yet
3 participants
@eric-with-a-c
Copy link
Collaborator

commented May 8, 2019

This merge adds support for the following elements:

  • User Metadata
  • Keywords
  • Notes

Additionally it adds support for XMLs that don't have a library element. When using the drag-and-drop features of FCP X the XML that is generated doesn't necessarily contain a library. This is the case when you drag an Event, a Project, or a Clip from FCP X to outside the app.

@codecov-io

This comment has been minimized.

Copy link

commented May 8, 2019

Codecov Report

Merging #515 into master will increase coverage by 0.17%.
The diff coverage is 98.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
+ Coverage   88.64%   88.81%   +0.17%     
==========================================
  Files          68       68              
  Lines        7264     7388     +124     
==========================================
+ Hits         6439     6562     +123     
- Misses        825      826       +1
Impacted Files Coverage Δ
...lineio_contrib/adapters/tests/test_fcpx_adapter.py 98.36% <100%> (+2.36%) ⬆️
opentimelineio_contrib/adapters/fcpx_xml.py 94.61% <98.2%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a48bdce...858f308. Read the comment docs.

eric-with-a-c
@ssteinbach
Copy link
Member

left a comment

one tiny little pattern thing I noticed, but this looks like a good change. Thanks @eric-with-a-c !

Show resolved Hide resolved opentimelineio_contrib/adapters/fcpx_xml.py Outdated

@ssteinbach ssteinbach merged commit 4e93a8a into PixarAnimationStudios:master May 8, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.