Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCP XML: Adds a check on the NTSC element before reading its value #524

Conversation

@BadSingleton
Copy link
Contributor

commented Jun 6, 2019

Some softwares don't add the <NTSC> element to the <rate> element if the framerate
is not NTSC. Check if the element can be found before trying to
check it's value.

@codecov-io

This comment has been minimized.

Copy link

commented Jun 6, 2019

Codecov Report

Merging #524 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #524   +/-   ##
=======================================
  Coverage   81.28%   81.28%           
=======================================
  Files          72       72           
  Lines        2731     2731           
=======================================
  Hits         2220     2220           
  Misses        511      511
Flag Coverage Δ
#py27 81.29% <ø> (ø) ⬆️
#py36 81.29% <ø> (ø) ⬆️
#py37 81.29% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faa5827...ad008e1. Read the comment docs.

@reinecke
Copy link
Collaborator

left a comment

Nice catch!

@ssteinbach
Copy link
Member

left a comment

Looks good. Can you rebase to the latest master and push? After merging in the C++ branch stuff has changed around a bit.

Also, do we have a CLA from you? If you haven't, could you please see: https://opentimelineio.readthedocs.io/en/latest/tutorials/contributing.html

Thanks!

FCP XML: Adds a check on the NTSC element before reading its value
Some softwares don't add the <NTSC> element if the framerate
is not NTSC. Check if the element can be found before trying to
check it's value.

@BadSingleton BadSingleton force-pushed the BadSingleton:fcp_xml-check-if-ntsc-elem-exists branch from 1e81e22 to ad008e1 Aug 12, 2019

@BadSingleton

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2019

@ssteinbach Sorry for the late reply, yes there is a CLA covering me on the behalf of Unity.
@LauraJeffords is the legal person overseeing this.

@ssteinbach

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

Excellent. Sorry for the confusion!

@ssteinbach ssteinbach merged commit 689d3c4 into PixarAnimationStudios:master Aug 22, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.