Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.5->3.7 #526

Merged
merged 5 commits into from Jun 27, 2019

Conversation

Projects
None yet
3 participants
@ssteinbach
Copy link
Member

commented Jun 20, 2019

Move from python 3.5 to python 3.7

@ssteinbach ssteinbach added this to the Public Beta 11 milestone Jun 20, 2019

@ssteinbach ssteinbach requested a review from boredstiff Jun 20, 2019

@ssteinbach ssteinbach changed the title Python 3.6->3.7 Python 3.5->3.7 Jun 20, 2019

@ssteinbach ssteinbach force-pushed the ssteinbach:python37 branch from 715c67e to 3a25609 Jun 20, 2019

@ssteinbach

This comment has been minimized.

Copy link
Member Author

commented Jun 20, 2019

See #516

@codecov-io

This comment has been minimized.

Copy link

commented Jun 20, 2019

Codecov Report

Merging #526 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #526   +/-   ##
======================================
  Coverage    88.8%   88.8%           
======================================
  Files          68      68           
  Lines        7399    7399           
======================================
  Hits         6571    6571           
  Misses        828     828

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ec5cb7...39f8144. Read the comment docs.

@boredstiff

This comment has been minimized.

Copy link
Collaborator

commented Jun 20, 2019

Set up a pull request from me to you.

Two warnings:

First, a deprecation warning:

test_supported_suffixes_is_not_none (test_adapter_plugin.TestAdapterSuffixes) ... /Users/alex/dev/OpenTimelineIO/opentimelineio_contrib/adapters/advanced_authoring_format.py:35: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  from collections import Iterable

Easily fixable, and since VFX platform won't be targeting for 3.8, probably no need to worry about it for a long while. Still might be nice to clean it up.

Second - this wouldn't pass tests (at least for me) right away.

  ======================================================================
ERROR: test_aaf_adapter (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: test_aaf_adapter
Traceback (most recent call last):
  File "/usr/local/Cellar/python/3.7.3/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/loader.py", line 436, in _find_test_path
    module = self._get_module_from_name(name)
  File "/usr/local/Cellar/python/3.7.3/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/Users/alex/dev/OpenTimelineIO/opentimelineio_contrib/adapters/tests/test_aaf_adapter.py", line 35, in <module>
    from opentimelineio_contrib.adapters.aaf_adapter.aaf_writer import (
  File "/Users/alex/dev/OpenTimelineIO/opentimelineio_contrib/adapters/aaf_adapter/aaf_writer.py", line 30, in <module>
    import aaf2
ModuleNotFoundError: No module named 'aaf2'

I was hitting this even though pyaaf2 is installed in my venv. So to make it happy, I explicitly added pyaaf2 to tox, even though that shouldn't be necessary.

Additionally, I did a pip install with PySide 2 in the new Python37 virtual environment and view still works fine from quick tests.

image

Outside of that, once you accept my PR into your branch, this should be good to go, from what I can see.

Merge pull request #3 from boredstiff/python37
Update tox and manifest in preparation for Python37
@ssteinbach

This comment has been minimized.

Copy link
Member Author

commented Jun 20, 2019

@boredstiff I merged your PR. good call!

@ssteinbach ssteinbach requested a review from reinecke Jun 20, 2019

@ssteinbach ssteinbach merged commit c729612 into PixarAnimationStudios:master Jun 27, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@ssteinbach ssteinbach deleted the ssteinbach:python37 branch Jun 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.