Python 3.5->3.7 #526
@@ Coverage Diff @@ ## master #526 +/- ## ====================================== Coverage 88.8% 88.8% ====================================== Files 68 68 Lines 7399 7399 ====================================== Hits 6571 6571 Misses 828 828
Set up a pull request from me to you.
First, a deprecation warning:
Easily fixable, and since VFX platform won't be targeting for 3.8, probably no need to worry about it for a long while. Still might be nice to clean it up.
Second - this wouldn't pass tests (at least for me) right away.
I was hitting this even though pyaaf2 is installed in my venv. So to make it happy, I explicitly added pyaaf2 to tox, even though that shouldn't be necessary.
Additionally, I did a pip install with PySide 2 in the new Python37 virtual environment and view still works fine from quick tests.
Outside of that, once you accept my PR into your branch, this should be good to go, from what I can see.