Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xges: Fix tracks ordering #538

Merged
merged 1 commit into from Aug 7, 2019

Conversation

@thiblahute
Copy link
Contributor

commented Jul 12, 2019

The tracks should be loaded in reverse order for the XGES format.

Also in GES, layers (tracks in otio terms) do not have a track type
(tracks are global to the timeline which formalizes the outputed
types), thus we should try to keep audio and video tracks in the same
order during de-serialization.

@codecov-io

This comment has been minimized.

Copy link

commented Jul 12, 2019

Codecov Report

Merging #538 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #538   +/-   ##
=======================================
  Coverage   81.28%   81.28%           
=======================================
  Files          72       72           
  Lines        2731     2731           
=======================================
  Hits         2220     2220           
  Misses        511      511
Flag Coverage Δ
#py27 81.29% <ø> (ø) ⬆️
#py36 81.29% <ø> (ø) ⬆️
#py37 81.29% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1407f4a...480795e. Read the comment docs.

@ssteinbach
Copy link
Member

left a comment

Really small tweaks. Thanks!

Show resolved Hide resolved opentimelineio_contrib/adapters/xges.py Outdated
Show resolved Hide resolved opentimelineio_contrib/adapters/xges.py Outdated
Show resolved Hide resolved opentimelineio_contrib/adapters/xges.py Outdated
xges: Fix tracks ordering
The tracks should be loaded in reverse order for the XGES format.

Also in GES, layers (tracks in otio terms) do not have a track type
(tracks are global to the timeline which formalizes the outputed
types), thus we should try to keep audio and video tracks in the same
order during deserialization.

@thiblahute thiblahute force-pushed the thiblahute:xges_fixes branch from 379eb95 to 480795e Aug 5, 2019

@ssteinbach ssteinbach merged commit f38c21e into PixarAnimationStudios:master Aug 7, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.